Hi,

It’s -1 (binding) from me. I think you should use Apache Rat to check the 
release.

I checked:
- incubating in artifact name
- signatures and hashes are correct
- DISCLAIMER exists
- LICENSE is missing mention of 3rd party code included in the release
- NOTICE doesn't include correct text (missing URL)
- Files are missing ASF headers 
- no unexpected binary files
- I did not try to compile from the source

Files missing headers - you need to work out if these are 3rd party files or 
not.
./INSTALL.sh
./INSTALL_MAC.sh./entrypoint.sh./script.js./platform/consensus/ordering/common/algorithm/protocol_base.cpp./platform/consensus/ordering/common/algorithm/protocol_base.h./platform/consensus/ordering/poe/algorithm/poe.cpp./platform/consensus/ordering/poe/algorithm/poe.h./platform/statistic/test_server.sh./scripts/format.sh
./scripts/deploy/performance/pbft_performance.sh
./scripts/deploy/performance/poe_performance.sh
./scripts/deploy/performance/run_performance.sh
./scripts/deploy/script/deploy.sh
./scripts/deploy/script/env.sh
./scripts/deploy/script/generate_config.sh
./scripts/deploy/script/generate_key.sh
./scripts/deploy/script/load_config.sh./service/tools/contract/api_tools/example_contract/compile.sh./service/tools/contract/service_tools/start_contract_service.sh
./service/tools/kv/server_tools/start_kv_service.sh./service/tools/kv/server_tools/start_kv_service_monitoring.sh./service/tools/utxo/service_tools/start_utxo_service.sh./service/utxo/start_contract_server.sh
./tools/generate_certificate.sh
./tools/generate_client.sh
./tools/generate_cluster.sh
./tools/generate_key.sh

3rd party files that need to be mentioned in LICENSE:
./benchmark/protocols/poe/kv_server_performance.cpp
./common/crypto/hash.cpp
./common/crypto/hash.h
./common/crypto/hash_test.cpp
./common/crypto/key_generator.cpp
./common/crypto/key_generator.h
./common/crypto/mock_signature_verifier.h
./common/crypto/signature_utils.cpp
./common/crypto/signature_utils.h
./common/crypto/signature_verifier.cpp
./common/crypto/signature_verifier.h
./common/crypto/signature_verifier_interface.cpp
./common/crypto/signature_verifier_interface.h
./common/crypto/signature_verifier_test.cpp
./common/test/json_test.cpp
./common/test/test_macros.h
./common/utils/utils.cpp
./common/utils/utils.h
./node_modules/fs.realpath/old.js
./platform/consensus/ordering/common/framework/consensus.cpp
./platform/consensus/ordering/common/framework/consensus.h
./platform/consensus/ordering/common/framework/performance_manager.cpp
./platform/consensus/ordering/common/framework/performance_manager.h
./platform/consensus/ordering/common/framework/response_manager.cpp
./platform/consensus/ordering/common/framework/response_manager.h
./platform/consensus/ordering/common/framework/transaction_utils.cpp
./platform/consensus/ordering/common/framework/transaction_utils.h
./platform/consensus/ordering/poe/framework/consensus.cpp
./platform/consensus/ordering/poe/framework/consensus.h
./platform/consensus/ordering/poe/framework/consensus_test.cpp
./service/tools/utxo/wallet_tool/cpp/addr_utils.cpp
./service/tools/utxo/wallet_tool/cpp/addr_utils.h
./service/tools/utxo/wallet_tool/cpp/key_utils.cpp
./service/tools/utxo/wallet_tool/cpp/key_utils.h
./service/tools/utxo/wallet_tool/pybind/wallet_tools_py.cpp./node_modules/lodash.union/index.js./node_modules/lodash.difference/index.js./node_modules/brace-expansion/index.js./node_modules/ignore/index.js./node_modules/once/once.js./node_modules/inherits/inherits.js
...and many other files in node_modules

Kind Regards,
Justin







---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to