On Thu, Jul 16, 2009 at 02:53:34PM -0700, Roland Dreier wrote:
> Seems sane and quite useful, applied thanks

Thanks - I have a few other little quibbles I've noticed from using
verbs from C++:

* Missing const's in some function parameters
* Use of 'enum foo' as a type for a bit field. In C/C++
  or'ing enum members results in a type that is the enum
  base integral type, not the enum itself. g++ produces
  a warning by default. Very annoying :)

Are you interested in patches for these too?

-- 
Jason Gunthorpe <[email protected]>        (780)4406067x832
Chief Technology Officer, Obsidian Research Corp         Edmonton, Canada
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to