On Mon, Feb 22, 2016 at 2:17 AM, Simon Steiner <[email protected]> wrote:
> Hi, > > I have been using ant target release-dist, so we need this in mvn before > we remove build.xml. > agreed; however, we shouldn't need their equivalent in mvn with this initial merge; clearly, will need mvn deploy target to function before we do a new release; > > Checkstyle + findbugs should be added to: > https://builds.apache.org/job/xmlgraphics-commons-maven/configure agreed, which can be done post merge while transitioning to maven CI > > > Thanks > > -----Original Message----- > From: Glenn Adams [mailto:[email protected]] > Sent: 22 February 2016 08:53 > To: XML Graphics Project <[email protected]> > Subject: Re: [VOTE] Merge from xmlgraphics/commons/branches/maven to trunk. > > Thanks for checking, Simon. I have addressed these issues as follows: > > - removed symlinks, altering build.xml et al as needed to directly use > new src hierarchy (except test/images, which I've restored); > - change java version to 1.6 in POM; > - verify compile+test in both ant and maven using JDK 1.6, which > requires use of maven 3.2.5 (maven 3.3 requires JDK 1.7); > - verify checkstyle and findbugs ant targets, with both JDK 1.6 and 1.7; > - verify mvn checkstyle:check and findbugs:check goals, with both JDK > 1.6 (using maven 3.2.5) and JDK 1.7 (using maven 3.3.9); > > To run ant checkstyle and findbugs targets, ensure you add the following > (or equivalent) to build-local.properties: > > - checkstyle.location = > ${env.HOME}/work/checkstyle/checkstyle-5.5/checkstyle-5.5-all.jar > - findbugs.home.dir = ${env.HOME}/work/findbugs/findbugs-2.0.3 > > Since findbugs 3.0.1 requires JDK 1.7, we won't be able to use it until we > give up 1.6 as minimum JDK version. > > At this point, I can run the following without error on JDK 1.6 and 1.7 > (on Mac OSX El Capitan - 10.11): > > - ant clean junit > - ant checkstyle > - ant findbugs > - mvn clean test > - mvn checkstyle:check > - mvn findbugs:check > > I have not tested other ant targets or mvn goals. > > Note that once maven is configured and running successfully, it is my > intention to drop ant build support; though this is subject to discussion > and agreement by the PMC. However, for a while at least, we should be able > to maintain both build processes. > > Regarding Jenkins CI, my plan is to disable the current ant build config > and enable a new maven build config as soon as possible. > > Please check this branch against Windows if you have a chance; I don't do > Windows (any more). > > The VOTE is still active, so if anyone has a blocking issue, please post a > -1. Otherwise, I will go ahead with a merge by end of day Wednesday. > > > > On Sun, Feb 21, 2016 at 2:05 AM, Simon Steiner <[email protected] > > > wrote: > > > Hi, > > > > Does the symlink method work on windows? > > > > The pom has, findbugs 3 requires java 7 or later, we use findbugs > > 2.0.3 with ant CI job: > > <findbugs.version>3.0.1</findbugs.version> > > <java.version>1.7</java.version> > > > > Thanks > > > > -----Original Message----- > > From: Glenn Adams [mailto:[email protected]] > > Sent: 21 February 2016 07:00 > > To: XML Graphics Project <[email protected]> > > Subject: [VOTE] Merge from xmlgraphics/commons/branches/maven to trunk. > > > > I would like to start a vote on merging from > > xmlgraphics/commons/branches/maven to trunk. Please respond by > > Wednesday, 02/24, 1700Z. Lack of a response will be interpreted as +0. > > > > In addition to adding a Maven POM, this merge will begin the process > > of migrating to the typical maven directory hierarchy, i.e., > > > > src/main/java > > src/main/resources > > src/test/java > > src/test/resources > > > > etc. > > > > I have retained symbolic links to permit ant builds to continue to > > function. > > > > The following run without error (on my platform): > > > > mvn clean test > > ant clean junit > > > > I am using the following tool versions: > > > > $ mvn -v > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > > 2015-11-10T09:41:47-07:00) > > Maven home: /opt/local/share/java/maven3 Java version: 1.7.0_80, vendor: > > Oracle Corporation Java home: > > /Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home/jre > > Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", > > version: "10.11.3", arch: "x86_64", family: "mac" > > > > $ ant -version > > Apache Ant(TM) version 1.9.6 compiled on June 29 2015 Please let me > > know if you encounter problems on JDK 6. > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
