commit: 213454a448e5cd8794042a49930a37b27a4d2bbd
Author: Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Sun Jul 20 06:09:17 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Jul 22 22:30:54 2025 +0000
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=213454a4
isolated-functions.sh: refrain from using the integer attribute in
__dump_trace()
The only discernible purpose of the integer attribute is to entice
inexperienced bash programmers into improving their bug yield.
Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>
bin/isolated-functions.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
index eda6ccd3ad..9270a344d4 100644
--- a/bin/isolated-functions.sh
+++ b/bin/isolated-functions.sh
@@ -32,9 +32,8 @@ shopt -s extdebug
# [whitespacing for filenames],
# [whitespacing for line numbers])
__dump_trace() {
+ local strip=${1:-1} filespacing=$2 linespacing=$3
local sourcefile funcname lineno n p
- declare -i strip=${1:-1}
- local filespacing=$2 linespacing=$3
# The __qa_call() function and anything before it are portage internals
# that the user will not be interested in. Therefore, the stack trace