I've noticed that some init scripts call start-stop-daemon when the
"daemon" is really a shell script. This needs to be changed so that
either

1) The call to start-stop-daemon is removed in the init script.
This is logical as shell scripts are not daemons

2) Embed the functionality of the shell script in the init script so
that the start-stop-daemon command really does launch the daemon.

This change is required as future versions of baselayout will wrap the
start-stop-daemon command to test that it has actually started and is
still running. If it's not running then return failure instead of
returning success as it does at the moment. Obviously this will fail if
we're trying to launch a shell script!

This solves many bugs where daemons launch fine and return success to
start-stop-daemon but then die due to an invalid configuration file -
named/bind is a good example of this.

The only ebuild that I know of that requires this change is
net-mail/courier-imap

There may be others in the tree - only the ebuild maintainers will know.
If you're an ebuild maintainer and install an init script, please check
this otherwise when a baselayout-1.12.0 hits things will break.

Another thing to stop doing is blindly rm -f pidfiles without testing to
see if they exist or not as we now clean up pidfiles for you - if we
can. This won't cause any problems other than an error message, so it's
not a major issue, but I thought I'd let people know.

Thanks

-- 
Roy Marples <[EMAIL PROTECTED]>
Gentoo Linux Developer

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to