-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 You have missed the situation when the daemon doesn't create any pid file, which start-stop-daemon can do. Also, it seems ok to me to use the start-stop-daemon in the stop() function (combined with the --retry $TIME option is really great for daemons that require a longer time to finish). The rest, I agree with you.
Roy Marples wrote: > I've noticed that some init scripts call start-stop-daemon when the > "daemon" is really a shell script. This needs to be changed so that > either > > 1) The call to start-stop-daemon is removed in the init script. > This is logical as shell scripts are not daemons > > 2) Embed the functionality of the shell script in the init script so > that the start-stop-daemon command really does launch the daemon. > > This change is required as future versions of baselayout will wrap the > start-stop-daemon command to test that it has actually started and is > still running. If it's not running then return failure instead of > returning success as it does at the moment. Obviously this will fail if > we're trying to launch a shell script! > > This solves many bugs where daemons launch fine and return success to > start-stop-daemon but then die due to an invalid configuration file - > named/bind is a good example of this. > > The only ebuild that I know of that requires this change is > net-mail/courier-imap > > There may be others in the tree - only the ebuild maintainers will know. > If you're an ebuild maintainer and install an init script, please check > this otherwise when a baselayout-1.12.0 hits things will break. > > Another thing to stop doing is blindly rm -f pidfiles without testing to > see if they exist or not as we now clean up pidfiles for you - if we > can. This won't cause any problems other than an error message, so it's > not a major issue, but I thought I'd let people know. > > Thanks > - -- Alin DOBRE Romanian Lead Translator Gentoo Documentation Project: http://www.gentoo.org/doc/en/ Gentoo.RO Community: http://www.gentoo.ro/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCLzhTmG51ym6Hu9gRAgRaAKC+qANU2rD8/06PGovb7npS0MW9eACeMW3E PXnQntKomXYDknzN0Fgi8mE= =zXzI -----END PGP SIGNATURE----- -- [email protected] mailing list
