Donnie Berkholz wrote:
>> 1.1 www-servers/resin/resin-3.1.4.ebuild
>> src_unpack() {
>>
>> unpack ${A}
>> for i in "${WORKDIR}"/${PV}/resin-${PV}-*; do
>> epatch "${i}"
>> done;
>
> How about:
>
> epatch "${WORKDIR}"/${PV}/resin-${PV}-*
Leftover from tests, will be fixed with next bump.
>> src_compile() {
>>
>> append-flags -fPIC -DPIC
>
> Somehow it seems wrong to append this for a whole package...
It builds only one .so library - the rest is in Java, so I don't see a problem
with using append-flags.
>> src_install() {
>>
>> make DESTDIR="${D}" install || die
>
> Does emake work? If not, please add a comment to that effect.
Didn't test, but I will with next bump.
>> einfo "Fixing permissions..."
>> chown -R resin:resin "${D}${RESIN_HOME}"
>> chown -R resin:resin "${D}/etc/resin"
>> chown -R resin:resin "${D}/var/log/resin"
>> chown -R resin:resin "${D}/var/lib/resin"
>> chown -R resin:resin "${D}/var/run/resin"
>>
>> chmod 644 "${D}/etc/conf.d/resin"
>> chmod 755 "${D}/etc/init.d/resin"
>> chmod 750 "${D}/var/lib/resin"
>> chmod 750 "${D}/var/run/resin"
>> chmod 750 "${D}/etc/resin"
>
> Again, fowners/fperms can make this a bit easier to read.
I'll fix it with next bump.
--
Krzysiek Pawlik <nelchael at gentoo.org> key id: 0xBC555551
desktop-misc, java, apache, ppc, vim, kernel...
signature.asc
Description: OpenPGP digital signature
