Ben de Groot wrote: > It may be 2 lines less, but it is 42 characters more. > Plus, I dislike caps. :-p
Well the original patch used DEFAULT_CONFIG_ENABLE and DEFAULT_CONFIG_WITH and didn't invoke any subshells. I'm not sure what the thinking behind changing it was, unless it was a straight lift from paludis. As for caps, that's kinda standard within ebuild-land if something crosses functional boundaries, but I agree they're ugly ;) (In Bash, I'd only use them for constants or env vars.)
