Hello,

Our bash-completion.eclass is awful and ugly. I'm not even talking
about flags and stuff now but dobashcompletion() itself.

That function doesn't follow do*() argument scheme; it matches rather
one used by new*() funcs. Sadly, a number of ebuilds is using that
scheme to rename installed file.

Furthermore, it uses two eclass variables to switch the behavior.

BASHCOMPFILES allows it to install multiple files (but works only if no
arguments are passed).

BASHCOMPLETION_NAME renames the installed file (if BASHCOMPFILES is not
used) and makes it ignore the second argument.

I think the way to go would be to reimplement it completely. Maybe just
put dobashcomp() and newbashcomp() functions in eutils (to not collide)
and deprecate bash-completion.eclass?

-- 
Best regards,
Michał Górny

Attachment: signature.asc
Description: PGP signature

Reply via email to