Calling "use" in global scope isn't allowed so what are you suggesting
they do instead?
On Tue, Jun 12, 2012 at 11:02 PM, Mike Frysinger <vap...@gentoo.org> wrote:
> i've noticed a growing trend where people put setup of variables into
> pkg_setup that only matter to src_* funcs presumably so they don't have to
> call the respective src_* func from an inherited eclass. unfortunately this
> adds pointless overhead to binpkgs. can we please move away from this
> practice ?
>
> i've seen this with a good number of the GNOME packages like:
> pkg_setup() {
> G2CONF="${G2CONF}
> --disable-bash-completion
> --disable-hal
> --disable-schemas-compile
> --with-dbus-service-dir=/usr/share/dbus-1/services
> $(use_enable afp)
> $(use_enable archive)
> $(use_enable avahi)
> $(use_enable bluetooth obexftp)
> $(use_enable bluray)
> $(use_enable cdda)
> $(use_enable fuse)
> $(use_enable gdu)
> $(use_enable gphoto2)
> $(use_enable ios afc)
> $(use_enable udev)
> $(use_enable udev gudev)
> $(use_enable http)
> $(use_enable gnome-keyring keyring)
> $(use_enable samba)"
> }
>
> ugh
> -mike
