On Wed, 20 Jun 2012 18:45:31 +0200 Ulrich Mueller <u...@gentoo.org> wrote: > I'd say that EAPI 5 should provide an "apply_patches_here" function > that can be called by ebuilds, but if the ebuild hasn't called the > function, then it should fall back to applying user patches just after > src_prepare.
But applying user patches after src_prepare is wrong. We already had this discussion. > > We had this discussion in the original thread. If we're just looking > > for a feature that "might work sometimes", there's no point sticking > > any of this in the EAPI at all. > > I don't see why the above wouldn't work. The user still has complete > control, because he can always patch (e.g.) configure along with > configure.in. Not really, since patches mess with timestamps. > Then there are ebuilds that don't call eautoreconf, in the first > place. Should we require that all of them inherit autotools now, just > for the unlikely case that user patches could be applied? If the aim is to provide a working feature to users, yes. The alternative is to not provide user patches support. -- Ciaran McCreesh
signature.asc
Description: PGP signature
