On Wed, 20 Jun 2012 17:44:36 +0200 Ulrich Mueller <u...@gentoo.org> wrote: > >>>>> On Wed, 20 Jun 2012, Ciaran McCreesh wrote: > > I believe we consider the user patches feature to be finalised, > > [...] > > I disagree with this. As it is currently worded, every ebuild would be > required would be required to call a special function in src_prepare. > This is the worst possible solution, IMHO.
Every ebuild that defines its own src_prepare, yes. That's the point: the package mangler can't know where to apply patches itself otherwise, and user patches are rare enough that developers are very likely to forget to check if they aren't made to. We had this discussion in the original thread. If we're just looking for a feature that "might work sometimes", there's no point sticking any of this in the EAPI at all. -- Ciaran McCreesh
signature.asc
Description: PGP signature