-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 14/08/15 07:16 AM, hasufell wrote: > On 08/14/2015 01:10 PM, Andrew Savchenko wrote: >> On Fri, 14 Aug 2015 02:11:09 -0700 Daniel Campbell (zlg) >> wrote: >>> I honestly don't see the point of this when `git log` or even >>> `git diff` or standard `diff` will tell you if what's in your >>> overlay differs from the source. With some bash magic it >>> could even be automated. The point of that 'feature' is to >>> see what, if anything, has changed between one's overlay and >>> Gentoo's running tree. A diff would not only be able to tell >>> you *if* anything changed, but also *what*, without adding >>> around 5-7 extra bytes per ebuild. Sure, it's only bytes, but >>> when multiplied against the number of ebuilds we have, it can >>> make a few hundred KB difference. When expanded, that number >>> multiplies. Is it worth adding this extra bloat to something >>> that a standard utility can expose better than a hash? >> >> Agree here. Also I don't like the idea of post-modifying >> content of signed commits: files developers committed to the >> tree should be the same users get. As a side effect this will >> simplify tree consistency checks and forensics. >> > > The files are already modified (e.g. Manifest) for rsync, so > this arguments becomes a moot point. > >
I think it'd also be handy, in terms of debugging rsync's gone awry (especially in the case of unofficial rsync mirrors) if the ebuilds contained the commit-id; it'd provide a more simple way to check where in git history this particular ebuild was committed. I'm thinking especially in cases where for whatever reason an rsync doesn't synchronize the entire repo. That said, since $Id$ is apparently not going to be a commit-id that can be checked quickly by 'git show' or searched for in 'git log', I'm not sure if that makes it as easy to check as I'm imagining... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlXN/DUACgkQAJxUfCtlWe0TugEAr+eKeiFcPrNLfbR2vrN06U7E cldl+tb+rjJZT7NMZ3UBANV4x8b1fj4NQu+DO38bYKCtZ7NZdNWALUXiDxYSf9mO =c00L -----END PGP SIGNATURE-----
