On 30 Oct 2015 18:20, Michał Górny wrote: > On Fri, 30 Oct 2015 12:03:59 +0000 (UTC) "Justin Lecher" wrote: > > commit: df8e399c9bac2dc30d7cf69c2462a81729a3ae69 > > Author: Justin Lecher <jlec <AT> gentoo <DOT> org> > > AuthorDate: Fri Oct 30 10:18:05 2015 +0000 > > Commit: Justin Lecher <jlec <AT> gentoo <DOT> org> > > CommitDate: Fri Oct 30 12:03:49 2015 +0000 > > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df8e399c > > > > eclass: Use consistent place for then in if clause > > Excuse me but who are you exactly to take a random eclass and commit > random style changes inside without even bothering to contact > the author?
your attitude is wrong and is a great example of why people in the project
are hesitant to touch anything anymore
> > Signed-off-by: Justin Lecher <jlec <AT> gentoo.org>
> >
> > eclass/distutils-r1.eclass | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> > index 185dd4f..dbd27a7 100644
> > --- a/eclass/distutils-r1.eclass
> > +++ b/eclass/distutils-r1.eclass
> > @@ -322,8 +322,7 @@ distutils-r1_python_prepare_all() {
> >
> > _distutils-r1_disable_ez_setup
> >
> > - if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]]
> > - then
> > + if [[ ${DISTUTILS_IN_SOURCE_BUILD} && ! ${DISTUTILS_SINGLE_IMPL} ]];
> > then
>
> This was intentionally wrapped to stay within 72-column line width. Not
> saying the eclass is perfect in keeping text width, especially with
> others committing random changes to it, but that's no reason to
> introduce further offenders.
Gentoo has never had a hard 80-col rule let alone 72-cols. forcing a wrap
here makes no sense and the new version is an improvement.
-mike
signature.asc
Description: Digital signature
