On Wed, Aug 31, 2016 at 11:09 PM, Mike Gilbert <flop...@gentoo.org> wrote: > On Wed, Aug 31, 2016 at 12:52 PM, Alexis Ballier <aball...@gentoo.org> wrote: >> On Sun, 28 Aug 2016 19:28:48 +0200 >> "Paweł Hajdan, Jr." <phajdan...@gentoo.org> wrote: >> >>> D. Patch chromium not to require newer ffmpeg >> >> >> You can use the attached patch. Quick test on youtube showed it works. > > Nice! Testing this now.
The code you have disabled seems to be comparing color space id values as defined in src/ui/gfx/color_space.h to the equivalent values in the ffmpeg API. I would assume this is because some chromium code uses them interchangeably. What happens if we pass one of those ids to an ffmpeg function that doesn't understand it? I'm afraid this might break in some subtle way.