On Wed, 18 Jan 2017 08:19:19 +0100 Dirkjan Ochtman <d...@gentoo.org> wrote:
> This sounds like a much better strategy to me. We're expecting people > to check things that should be easy to check for machines. Yes, some > people (like myself) will always use repoman to commit, but it would > be much better if something this important (because it basically > delays other updates to users everywhere) is checked by an automated > process for every push, and disallows pushes like this. That's not viable, mostly because the performance cost of doing so is significantly time consuming, that it would block `git push` for minutes at a time, and all users performing pushes would have to wait in a queue for several minutes per push. At scale, I'd expect the push'es to start timing out. That's why the gating is done between git-master and rsync-master, not between the user and git-master. Just imagine needing to wait for a travis test run to complete on the end of every commit, stacked with there being 20 different jobs per push and having to use the slower non-container architecture. Nobody would be working on *that* project, or people would simply make much larger push-queues, increasing the amount of conflicts and progressive de-coherence. > > > I can see if it's something I need to fix with my code. But it's been > > a while since that's been the case, so all the failures these days are > > primarily for the previously mentioned issues. > > That makes sense. My other comment initially reading your email would > be, send those emails to gentoo-core or -project or whatever. If > others don't get to feel the pain (of every half-hour error emails, > for example), they will be much less compelled to fix the problem. So > absorbing this "pain" into just you or infra makes us less scalable as > a distribution, and less likely that someone will feel motivated to > add the extra bits of automation (like a git hook) that will make this > problem go away. +1 , I was aware that "somebody" knew the tree was breaking, but I had no understanding of what was breaking, why it was breaking, or even how people knew it was breaking. And so upon reading the original email hearing that people could even be notified of this fact, made me immediately question what I should be doing to see said notifications, or if there was even a page that I could check periodically to know what the state of the sync was. As the saying goes, information and awareness of the problem is a critical first step to solving the problem.
pgpzEz2qctT1T.pgp
Description: OpenPGP digital signature