>>>>> On Mon, 26 Jun 2023, Sam James wrote:
> +
> + # Avoid creating ${WORKDIR}_build (which is above WORKDIR).
> + # TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
> + # See bug #889420.
> + if [[ ${S} == ${WORKDIR} && ${BUILD_DIR} == ${WORKDIR}_build ]]
> ; then
I'd suggest adding quotes to the RHS of the expression, to prevent
globbing.
But I think what you really want is to check whether ${BUILD_DIR}
(whatever its name is) is a subdirectory of ${WORKDIR}? Maybe a test
like this would make that intent clearer:
if [[ ${BUILD_DIR} != "${WORKDIR}"/* ]]; then
> + eqawarn "QA notice: S=WORKDIR is deprecated for
> cmake.eclass."
> + eqawarn "Please relocate the sources in src_unpack."
> + BUILD_DIR="${WORKDIR}"/${P}_build
> + fi
