Ulrich Mueller <u...@gentoo.org> writes:

>>>>>> On Mon, 26 Jun 2023, Sam James wrote:
>
>> +
>> +            # Avoid creating ${WORKDIR}_build (which is above WORKDIR).
>> +            # TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
>> +            # See bug #889420.
>> +            if [[ ${S} == ${WORKDIR} && ${BUILD_DIR} == ${WORKDIR}_build ]] 
>> ; then
>
> I'd suggest adding quotes to the RHS of the expression, to prevent
> globbing.

I'm fine with quoting the RHS, but I don't think it's worth making the
other changes given this works and it's already an edge case.

Attachment: signature.asc
Description: PGP signature

Reply via email to