On 05/11/2012 09:39 AM, Mike Frysinger wrote:
> +multijob_finish() {
> + local ret=0
> + while [[ ${mj_num_jobs} -gt 0 ]] ; do
> + multijob_finish_one
> + : $(( ret += $? ))
> + done
> + # Let bash clean up its internal child tracking state.
> + wait
> + return ${ret}
> +}Wouldn't it be better to use $(( ret |= $? )) there, in order to avoid a possible integer overflow? Other than that, the patch looks good to me. -- Thanks, Zac
