On Monday 13 January 2014 19:08:30 [email protected] wrote: > From: Chris Reffett <[email protected]>
you might want to set ~/.gitconfig to have your name/email so that git
sendemail uses the right info in the actual e-mail From: field
> + undefined_phases_re =
> re.compile(r'^\s*(src_configure|src_prepare)\s*\(\)')
you use re.match, so technically the ^ is redundant
i'd suggest merging the regex a little:
r'^\ssrc_(configure|prepare)\s*\(\)'
could check for pkg_pretend/pkg_info too (it's new to EAPI 4)
the regex is naive and can match valid ebuilds. consider ones that handle
$EAPI itself and will call the right funcs as necessary. can you check the
tree to see if anyone is doing this ? if so, we should drop a note to the dev
list and get them fixed up.
-mike
signature.asc
Description: This is a digitally signed message part.
