On Sun, 23 Feb 2014 18:31:54 +0100
Sebastian Luther <sebastianlut...@gmx.de> wrote:
> Am 23.02.2014 09:07, schrieb Brian Dolbec:
> > ---
> > pym/_emerge/actions.py | 5 +++++
> > pym/_emerge/depgraph.py | 5 +++--
> > pym/_emerge/main.py | 5 +++++
> > pym/portage/package/ebuild/config.py | 3 +++
> > 4 files changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
> > index 95c5c14..a3f7813 100644
> > --- a/pym/_emerge/actions.py
> > +++ b/pym/_emerge/actions.py
> > @@ -2923,6 +2923,11 @@ def adjust_config(myopts, settings):
> > settings["PORTAGE_VERBOSE"] = "1"
> > settings.backup_changes("PORTAGE_VERBOSE")
> >
> > + if ("--verbose-slot-rebuilds" in myopts and
> > + myopts["--verbose-slot-rebuilds"] not in ("y","True")):
> > + settings["VERBOSE_SLOT_REBUILDS"] = "0"
> > + settings.backup_changes("VERBOSE_SLOT_REBUILDS")
>
> Why do you put that into the config class? In the resolver you should
> just do:
> if "--verbose-slot-rebuilds" in self._frozen_config.myopts:
>
> Otherwise looks good.
>
It is a command line option. This is where all the other command line
options were defined. How else is a user going to toggle the option?
And here I was worried about where to define the default... since it
needs to be defined depgraph.py, I ended up putting it in
pym/portage/package/ebuild/config.py. That seemed to be the default config.
But since depgraph.py is an _emerge namespace lib, if there is a better
place for it. Please speak up.
--
Brian Dolbec <dolsen>
