On 09/16/2014 02:37 PM, Bertrand Simonnet wrote: > > > On Tue, Sep 16, 2014 at 12:17 PM, Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > On 09/16/2014 11:17 AM, Bertrand Simonnet wrote: > > I moved the profile attributes detection logic into the python side as > > suggested (much cleaner). > > Thanks, that's better. I've got a couple more issues though: > > 1) Like global functions, global variables should also be unset in > __save_ebuild_env. So, we should unset PORTAGE_PROFILE_ATTRIBUTES there. > > Done > > 2) Instead of having _get_profile_attributes read the layout.conf files > directly, it would be nicer if we could integrated it with the > LocationsManager layout.conf parsing. For example, see the > intersecting_repos code inside the _addProfile method. > > This is much better. :)
I all looks very well done to me now. I'd encourage others on the list to review it now, in case there's anything that I missed. -- Thanks, Zac
