On 12/21/2015 07:04 AM, Alexander Berntsen wrote: > The patch looks OK. > > On 20/12/15 23:32, Zac Medico wrote: >> Since the Manifest "stable mtime" behavior could be have >> undiscovered bugs, disable it by default, and add a corresponding >> egencache option. > You have an English børk here -- "could be have".
Thanks, fixed. >> [PATCH v2] fixes preserved_stats to contain stat results for >> self.pkgdir even if the Manifest has been removed, and also >> explains the reasoning for disabling the stable mtime behavior by >> default. > Maybe this could go into the commit message? I'd not mind a more > verbose message for this. In v3 I've added a comment block to Manifest.write in order to document subtle issues involving the mtime of self.pkgdir that must be accounted for. -- Thanks, Zac
