On 12/22/2015 12:26 AM, Alexander Berntsen wrote: > On 21/12/15 20:57, Zac Medico wrote: >> Since the Manifest "stable mtime" behavior could have undiscovered >> bugs > This isn't exactly very motivating. "Since Foo could have bugs" > applies to pretty much any Python code >10 lines.
We could include micro-optimization as a motivation, since this option will eliminate some stat, listdir, and utime calls that should be pretty negligible in comparison to the overall cost of generating the manifest. I'm confident enough in the reliability of the stable mtime code, so from my perspective, micro-optimization is the most valid motivation. However, I'm not so sure that it's a good idea to disable stable mtime by default, since it seems like a reasonable behavior with negligible cost. > The patch itself looks OK though. Thank you! -- Thanks, Zac
