On Tue, Jul 01, 2003 at 10:50:35PM -0500, Kurt V. Hindenburg wrote:
[snip]
> http://www.cherrynebula.net/projects/portage-kvh/portage-kvh.html
> For example in my /etc/make.conf I have the line :
> DISTDIRS="/mnt/cdr /mnt/cdrw"
> Note: Some ebuilds hard-code their patch location to DESTDIR, this will 
> cause errors if the patch is in DESTDIRS.
Looking at this patch, it is definatly promising, but needs a bit more
work still.

I have a suggestion about how it is implemented.
Presently your patch has problems with a hardcoded DESTDIR, as you only
really hook into the unpack actions.

How about, for each package, make a directory
say ${PORTAGE_TMPDIR}/${P}/sources
and fill it with symlinks to the actual location of each item.
Then change DESTDIR to that directory for the remainder of the ebuild
run.

Remember to add something to clean it up afterwards.

This would enable all existing ebuilds to work without any
modifications. It would also make a lot of your logic quite a lot
simpler.

Two requests about your patch as well. 

In UNIX, ':' is used as a convention for a path element seperator for
the simple reason it is easier in general to parse, and can also allow
the entire string to remain a single argument without needing extra
quoting.

I haven't dug further to see where new stuff is downloaded to, but how
about just making it the last or first directory in the list.

-- 
Robin Hugh Johnson
E-Mail     : [EMAIL PROTECTED]
Home Page  : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ#       : 30269588 or 41961639
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85

Attachment: pgp00000.pgp
Description: PGP signature

Reply via email to