strk wrote:
On Wed, May 13, 2009 at 12:19:23AM -0400, Frank Warmerdam wrote:
Paul Ramsey wrote:
I'd like to hear from others on this.
OK - though I don't see the downside. Downstream packages only need
to check for, and use GEOSFree() if they want. We are just adding a
new option, not altering an existing one or removing anything.
Agreed, no compatibility problem adding a GEOSFree.
Folks,
OK, I've back ported the GEOSFree() function into the 3.1 branch.
Note, it will be very important to ensure that the C API version
is upgraded for the 3.1.1 release. I'm not sure how we remember
to do stuff like this. I see there have been a few fixes in the 3.1
branch:
http://trac.osgeo.org/geos/log/branches/3.1
Perhaps it would be appropriate for us to roll out a 3.1.1?
Only, it'll have to stay (I've read Mateusz suggesting using
type-specific destroyers).
I cannot imagine why a type specific destroyer would be needed
for simple malloc()/free() buffer allocations.
Worth going throught the CAPI header files and properly document
when to use GEOSFree on the return right above the function.
I have slightly modified the geos_c.h.in to reflect use of GEOSFree()
but I wonder if there is other documentation of the C API.
PS: I've noticed Frank added a ChangeLog entry manually.
Was that the way ? As I haven't touched it :(
I assumed this was expected practice since the ChangeLog exists
and is updated by at least some developers.
Best regards,
--
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up | Frank Warmerdam, warmer...@pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush | Geospatial Programmer for Rent
_______________________________________________
geos-devel mailing list
geos-devel@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/geos-devel
