Hey Sampo,
Sorry I haven't been following the work too closely, but my first initial
thoughts.
1. What would be the consequence of not using the naming convention and
just exposing the stored queries directly as they are named? Is it solely
to make it explicit that the type is a stored query, and requires extra
parameters to function?
2. We generally discourage users from editing configuration files directly
so not sure how much of an option that is. It would also make the feature
unusable with alternative backends like jdbcconfig. While I am not saying
it's a show stopper to have no config UI it would certainly be ideal.
-Justin
On Mon, May 19, 2014 at 4:27 AM, Sampo Savolainen <
[email protected]> wrote:
> Ok. I hadn't noticed you were this far along. I was proposing merging our
> changesets to avoid us from diverging from this point onwards. As you're
> almost done so we should be pretty safe from that.
>
> Andrea, Justin, or anyone: do you guys have any comments regarding the
> questions I brought up earlier when I started this thread?
>
>
> Sampo
>
>
> On Mon, May 19, 2014 at 11:54 AM, Niels Charlier <[email protected]> wrote:
>
>> There is currently a pull request for my changes being reviewed.
>> I'm not sure when your changes will be reviewed and by whom. But I assume
>> they need to be reviewed separately, and preferably not at the same time.
>> But it is already good that your changes have now a base from my branch.
>>
>> Regards
>> Niels
>>
>>
>> On 19/05/14 10:48, Sampo Savolainen wrote:
>>
>> Hi,
>>
>> Should I just create a pull request on your branch and then I could
>> continue work on a branch based off your branch? This would mean bundling
>> our changes into a single changeset. I haven't heard any opposition to this
>> idea, though. Thoughts?
>>
>>
>> Sampo
>>
>>
>> On Mon, May 19, 2014 at 11:23 AM, Niels Charlier <[email protected]> wrote:
>>
>>> Thanks for the merging Sampo, looks good.
>>>
>>> Cheers
>>> Niels
>>>
>>>
>>> On 15/05/14 11:09, Sampo Savolainen wrote:
>>>
>>> Hi,
>>>
>>> I've successfully merged my and Niels's work. It was surprisingly easy
>>> with only one minor conflict. I noticed that you have discussed having a
>>> shared branch for me, Niels and Reni. This would be wise indeed as the
>>> danger of us either working on the same thing or against each other is
>>> pretty big.
>>>
>>> The merged is at
>>> https://github.com/sampov2/geotools/tree/wfs-ng-improvements-sq
>>>
>>> Do note however that my work stretches out to the geoserver codebase
>>> as well, though there's not too many changes there to date. (
>>> https://github.com/sampov2/geoserver/tree/feature-wfsng-storedquery)
>>>
>>> We need to figure out who's responsible for the wfs-ng module in GS.
>>> Niels, Reni, have you built wfs-ng as a GS module yet? I've built one, but
>>> I made the mistake of naming it an "extension" instead of "community" so I
>>> probably have to at least redo that part.
>>>
>>>
>>> The main goal of my work is pretty much done. There are two things
>>> that need to be discussed though:
>>>
>>> 1. Stored query "feature type"
>>>
>>> As discussed when I started this feature, the stored queries are
>>> currently exposed as special feature types provided by the data source.
>>> There's a naming convention which then can be used to separate true feature
>>> types from stored queries. Is this still fine with everyone involved?
>>>
>>>
>>> https://github.com/sampov2/geotools/blob/wfs-ng-improvements-sq/modules/unsupported/wfs-ng/src/main/java/org/geotools/data/wfs/impl/WFSContentDataStore.java#L43
>>>
>>>
>>> 2. Configuration UI
>>>
>>> I haven't written an UI to configure the stored query parameter
>>> mappings. As cascading stored queries are quite rare, do you think such a
>>> GUI is needed? Maybe writing clear documentation on how the featuretype.xml
>>> needs to be amended would be fine?
>>>
>>> The configuration is required if the feature type should do dynamic
>>> mapping of query attributes (bbox, crs, etc) to stored query parameters.
>>> This configuration is not required for the SQL ViewParams to be mapped as
>>> stored query parameters. That happens automatically.
>>>
>>>
>>> Sampo
>>>
>>> --
>>> Sampo Savolainen
>>> R&D Director, Spatineo Oy
>>> [email protected]
>>> +358-407555649
>>> Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
>>> www.spatineo.com, twitter.com/#!/spatineo<http://twitter.com/#%21/spatineo>
>>> www.linkedin.com/company/spatineo-inc
>>>
>>> This message may contain privileged and/or confidential information.
>>> If you
>>> have received this e-mail in error or are not the intended recipient, you
>>> may not use, copy, disseminate, or distribute it; do not open any
>>> attachments, delete it immediately from your system and notify the sender
>>> promptly by e-mail that you have done so.
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>>> Instantly run your Selenium tests across 300+ browser/OS combos.
>>> Get unparalleled scalability from the best Selenium testing platform
>>> available
>>> Simple to use. Nothing to install. Get started now for
>>> free."http://p.sf.net/sfu/SauceLabs
>>>
>>>
>>>
>>> _______________________________________________
>>> Geoserver-devel mailing
>>> [email protected]https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>>> Instantly run your Selenium tests across 300+ browser/OS combos.
>>> Get unparalleled scalability from the best Selenium testing platform
>>> available
>>> Simple to use. Nothing to install. Get started now for free."
>>> http://p.sf.net/sfu/SauceLabs
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>>
>>
>>
>> --
>> Sampo Savolainen
>> R&D Director, Spatineo Oy
>> [email protected]
>> +358-407555649
>> Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
>> www.spatineo.com, twitter.com/#!/spatineo<http://twitter.com/#%21/spatineo>
>> www.linkedin.com/company/spatineo-inc
>>
>> This message may contain privileged and/or confidential information. If
>> you
>> have received this e-mail in error or are not the intended recipient, you
>> may not use, copy, disseminate, or distribute it; do not open any
>> attachments, delete it immediately from your system and notify the sender
>> promptly by e-mail that you have done so.
>>
>>
>>
>
>
> --
> Sampo Savolainen
> R&D Director, Spatineo Oy
> [email protected]
> +358-407555649
> Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
> www.spatineo.com, twitter.com/#!/spatineo
> www.linkedin.com/company/spatineo-inc
>
> This message may contain privileged and/or confidential information. If you
> have received this e-mail in error or are not the intended recipient, you
> may not use, copy, disseminate, or distribute it; do not open any
> attachments, delete it immediately from your system and notify the sender
> promptly by e-mail that you have done so.
>
>
> ------------------------------------------------------------------------------
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.
> Get unparalleled scalability from the best Selenium testing platform
> available
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
*Justin Deoliveira*
Vice President, Engineering | Boundless
[email protected]
@j_deolive <https://twitter.com/j_deolive>
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
