Hi Ben, I took a first shot at this, here is the PR: https://github.com/geoserver/geoserver/pull/1246
On Wed, Sep 30, 2015 at 10:40 PM, Ben Caradoc-Davies <b...@transient.nz> wrote: > > Stefano, this is not going to work for all cases. The problem is that > mapping files only need to declare one of these namespaces if the prefix is > used a targetElement xpath. I am sure that I have seen valid mapping files > that do not either. GML is used only via import in the target schema. > > One way to be sure is to use AppSchemaDataAccess.getSchema to get the > feature type, then get the XSD type smuggled in the user data map, and then > walk up parent XSD types until you find either GML 3.1 or GML 3.2 > AbstractFeatureType. The WFS standard states that feature types must be > subtypes of gml:AbstractFeatureType. Right, I took for granted that every app-schema mapping configuration would declare a GML namespace, but it's an unwarranted assumption. I followed your suggestion, but used AttributeType.getSuper() to walk the type hierarchy instead of inspecting XSD types, as it felt easier to code: it seems to be working ok, do you see any drawbacks in this approach? In my view no. A little ugly may be more maintainable than a new interface > that is only used in one case. There you go, ugly, but (hopefully) more maintainable. :-) > There are test fixtures in GeoServer gs-app-schema-test. I do not think > there are any Wicket test fixtures, but you should be able to add some > based on those in the GeoServer gs-web-* modules. I added two test classes extending GeoServerWicketTestSupport to gs-app-schema-test. I will address the other concerns in separate PR(s). Thanks again for the feedback! -- Best regards, Stefano Costa == GeoServer Professional Services from the experts! Visithttp://goo.gl/it488V for more information. == Dott. Stefano Costa Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.ithttp://twitter.com/geosolutions_it ------------------------------------------------------- AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
