Nope, not that one. You did find some issues with code removing 1 from the
pixel grid extents, if memory
serves me right.
Btw that issue you are pointing to might have been solved recently by
avoiding the large raster space coordinates
in image mosaic: https://osgeo-org.atlassian.net/browse/GEOT-5615
Cheers
Andrea
On Wed, Apr 5, 2017 at 1:59 PM, Niels Charlier <[email protected]> wrote:
> You mean this
>
> https://osgeo-org.atlassian.net/browse/GEOS-7793
>
> ?
>
>
> On 05-04-17 12:57, Andrea Aime wrote:
>
> Hi Devon,
> short answer is... I have no clue. Yes, indeed the path between RT and non
> RT cannot be the same, one works off a reader,
> the other off a coverage and the RT can influence what is being read (area
> and resolution).
>
> I would not blame the geometry per se though, some time ago Niels was
> reporting an "off by one" error somewhere in
> the coverage reading chain... but I don't remember if the thread was here
> or elsewhere, or if a ticket was opened.
> It could be the cause of the issue though.
>
> Niels, do you remember the thread in question?
>
> Cheers
> Andrea
>
>
> On Wed, Apr 5, 2017 at 2:15 AM, Devon Tucker <[email protected]>
> wrote:
>
>> The statistics all seem to be there and fine. As far as I can tell, the
>> ColorMap itself seems to generate fine. The example, at least when viewed
>> at full extents looks fine and exactly like it does in the test case data.
>> The problem only occurs at certain scales and extents.
>>
>> Right now I'm looking at the various bits of the rendering pipeline
>> (RenderedImageMapOutputFormat.directRasterRender) that get invoked when
>> you have a a RenderingTransformation vs. without one. There are definitely
>> some differences there, in terms of the code paths taken. The one thing I
>> do notice is that the the GridGeometries of the coverage after the
>> rendering transformation is applied vs. the grid geometry when the coverage
>> is read without a rendering transform are slightly different, which I think
>> is maybe causing the issue?
>>
>> For example after the rendering transformation the coverage grid geometry
>> looks like this:
>>
>> GridGeometry2D[GridEnvelope2D[1..7, 2..12], PARAM_MT["Affine",
>> PARAMETER["num_row", 3],
>> PARAMETER["num_col", 3],
>> PARAMETER["elt_0_0", 0.5742214584350587],
>> PARAMETER["elt_0_2", 6.840767460515945],
>> PARAMETER["elt_1_1", -0.159840087890625],
>> PARAMETER["elt_1_2", 43.519122374398364]]]
>>
>> And without doing the rendering transformation, the coverage looks like
>> this:
>>
>> GridGeometry2D[GridEnvelope2D[0..7, 0..11], PARAM_MT["Affine",
>> PARAMETER["num_row", 3],
>> PARAMETER["num_col", 3],
>> PARAMETER["elt_0_0", 0.5742214584350587],
>> PARAMETER["elt_0_2", 7.414988918951003],
>> PARAMETER["elt_1_1", -0.159840087890625],
>> PARAMETER["elt_1_2", 43.19944219861711]]]
>>
>> I think this would explain the pixels cut off on the right and bottom?
>> But I'm not sure. The big difference I've noticed in the two code paths is
>> that when doing the coverage read while performing the rendering
>> transformation the read is done against the coverage reader directly, but
>> otherwise a GridCoverageReaderHelper is used. I still need to look into
>> what the differences might be there, but there's a lot of moving parts. I
>> may just try to plug the GridCoverageReaderHelper into the former code path
>> and see what pops out, just as an experiment.
>>
>> Cheers
>>
>> On Tue, Apr 4, 2017 at 2:33 AM, Andrea Aime <[email protected]
>> > wrote:
>>
>>> Hi Devon,
>>> going by memory the dynamic color map module depends on coverage
>>> statistics metadata
>>> derived in GDAL called "PAM_DATASET". Did you check the requirements and
>>> followed the
>>> necessary steps?
>>>
>>> http://docs.geoserver.org/stable/en/user/community/colormap/
>>> index.html#dynamiccolormap-requirements
>>>
>>> Cheers
>>> Andrea
>>>
>>>
>>> On Mon, Apr 3, 2017 at 11:26 PM, Devon Tucker <[email protected]>
>>> wrote:
>>>
>>>> Hi all,
>>>>
>>>> Wondering if anyone has any hints as to what might be causing this
>>>> issue:
>>>>
>>>> https://osgeo-org.atlassian.net/browse/GEOS-8070
>>>>
>>>> Even if it's just where in the code I might look for the issue. I
>>>> looked at the actual ColorMap generation, and that seems fairly straight
>>>> forward so I'm not sure if the problem is there. Otherwise I'm not so sure.
>>>> My first thought is that something's not being buffered correctly or
>>>> something along those lines, but I wouldn't know where to start.
>>>>
>>>> ------------------------------------------------------------
>>>> ------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Geoserver-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>
>>>>
>>>
>>>
>>> --
>>> ==
>>> GeoServer Professional Services from the experts! Visit
>>> http://goo.gl/it488V for more information.
>>> ==
>>>
>>> Ing. Andrea Aime
>>> @geowolf
>>> Technical Lead
>>>
>>> GeoSolutions S.A.S.
>>> Via di Montramito 3/A
>>> 55054 Massarosa (LU)
>>> phone: +39 0584 962313 <+39%200584%20962313>
>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>>>
>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>>> principi dettati dal D.Lgs. 196/2003.
>>>
>>>
>>>
>>> The information in this message and/or attachments, is intended solely
>>> for the attention and use of the named addressee(s) and may be confidential
>>> or proprietary in nature or covered by the provisions of privacy act
>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>>> copying, distribution, or either dissemination, either whole or partial, is
>>> strictly forbidden except previous formal approval of the named
>>> addressee(s). If you are not the intended recipient, please contact
>>> immediately the sender by telephone, fax or e-mail and delete the
>>> information in this message that has been received in error. The sender
>>> does not give any warranty or accept liability as the content, accuracy or
>>> completeness of sent messages and accepts no responsibility for changes
>>> made after they were sent or for other risks which arise as a result of
>>> e-mail transmission, viruses, etc.
>>>
>>> -------------------------------------------------------
>>>
>>
>>
>
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39 339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
> -------------------------------------------------------
>
>
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
