Hi Andrea, OK, I changed the way to activate the option (vendorOption -> system variable), but I can't create a pull request. I get the following error from my IDE:
Push failed: unable to access 'https://github.com/geotools/geotools/': The requested URL returned error: 403 Maybe I should have created my fork on github first instead of checking out directly from geotools/geotools ? I'll try this tomorrow. Now that I removed the vendor option, there is only one file changed (out of test files) Cheers, Michaël ________________________________ De : andrea.a...@gmail.com [andrea.a...@gmail.com] de la part de Andrea Aime [andrea.a...@geo-solutions.it] Date d'envoi : lundi 24 août 2015 10:35 À : Michael Michaud Cc : geoserver-users@lists.sourceforge.net; Mathieu Lemarchand; Arnaud Braun Objet : Re: [Geoserver-users] TR : Line label placement improvement Hi Michael, I've been hoping to find the time to do something similar for quite a while now, so this is certainly welcomed. I'd suggest you make a pull request with these changes enabled by default, and maybe have a system variable to disable it in case we find situations in which the performance slowdown is noticeable? Cheers Andrea On Mon, Aug 24, 2015 at 10:22 AM, Michael Michaud <michael.mich...@ign.fr<mailto:michael.mich...@ign.fr>> wrote: ________________________________ Hi Andrea, hi list, We would like to submit a patch to improve line label placement in Geotools. We are producing maps with a lot of street names using Geoserver. We noticed that many labels could not be placed because areas used to manage conflicts are quite big when labels follow diagonal directions. We decided to manage the label index using "letters" bounding boxes rather than "label" bounding boxes. This improve noticeably the number of placed labels (it is not possible to tell how many more as it is highly data-dependant). The performance penalty does not seem very high (indeed, we could not really measure it). Currently, we have implemented the change as a vendor option named "letterConflictEnabled". But if the code is good enough, it could also replace the current one at some point. Please, let us know if you're interested by this patch. It includes some unit tests and can be submitted as a PullRequest on the current GeoTools 14-SNAPSHOT. Here attached is a small document explaining the change. Michaël Michaud and Mathieu Lemarchand for Institut Géographique National (France) ------------------------------------------------------------------------------ _______________________________________________ Geoserver-users mailing list Geoserver-users@lists.sourceforge.net<mailto:Geoserver-users@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/geoserver-users -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ Geoserver-users mailing list Geoserver-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-users
