I a going to assume this is your pull request here ( https://github.com/geotools/geotools/pull/948). We should probably be discussing it on geotools list. Let me review quickly now ...
-- Jody Garnett On 25 August 2015 at 08:58, Michael Michaud <michael.mich...@ign.fr> wrote: > Hi, > > Thank you for the help, > I think you get the pull request now. > > I added a static variable DISABLE_LETTER_LEVEL_CONFLICT in LabelCacheImpl > to be able to disable the new behaviour from system property > "org.geotools.labelcache.disableLetterLevelConflict". > It should probably be final but I needed to switch the option on and off > in the unit tests. > > Let us know if there is something else we can do to validate the patch. > > Michaël > ------------------------------ > *De :* andrea.a...@gmail.com [andrea.a...@gmail.com] de la part de Andrea > Aime [andrea.a...@geo-solutions.it] > *Date d'envoi :* lundi 24 août 2015 20:37 > *À :* Michael Michaud > *Cc :* geoserver-users@lists.sourceforge.net; Mathieu Lemarchand; Arnaud > Braun > *Objet :* Re: RE : [Geoserver-users] TR : Line label placement improvement > > On Mon, Aug 24, 2015 at 8:34 PM, Michael Michaud <michael.mich...@ign.fr> > wrote: > >> Hi Andrea, >> >> OK, I changed the way to activate the option (vendorOption -> system >> variable), but I can't create a pull request. I get the following error >> from my IDE: >> >> Push failed: >> unable to access 'https://github.com/geotools/geotools/': The requested >> URL returned error: 403 >> > > You are trying to push to the main repository, this is not a pull requset > :-) > > >> >> Maybe I should have created my fork on github first instead of checking >> out directly from geotools/geotools ? >> > You should create your fork, push your branch there, and then from that > one, > you'll be able to make a pull request (just check your project's github > page after > pushing the branch) > > More info on the internet, e.g., here: > https://help.github.com/articles/creating-a-pull-request/ > > Cheers > Andrea > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Geoserver-users mailing list > Geoserver-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-users > >
------------------------------------------------------------------------------
_______________________________________________ Geoserver-users mailing list Geoserver-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-users
