Yes yes, that's definitely what I mean. I put that in the original post to the list, but perhaps I wrote it in a convoluted way. No problem getting the conversion "knots->barb", it's just a matter of how the pennant is drawn. Now outlined, should be filled instead. Just a very minor issue, but my future viewers of the layer will definitely comment on this...

Thanks for the great feedback and support here!

N.

PS. I could not believe I could go from scratch to now having a server serving map layers with both time and elevation dimensions in less than 3 days (and that included finding and converting the data source). Such a great product. DS.

On 2021-03-11 16:40, Daniele Romagnoli wrote:
Yep,
I'm pretty sure Niklas was referring about that empty outline instead of a filled black triangle.

I think that the ranges rounding (i.e. 48-52 -> 50) is already handled here: https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarbsFactory.java#L307 <https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarbsFactory.java#L307> where it computes the index of the graphic mark to be used for the provided speed.

Regards,
Daniele


On Thu, Mar 11, 2021 at 3:04 PM Richard Duivenvoorde <rdmaili...@duif.net <mailto:rdmaili...@duif.net>> wrote:

    Did Nikas maybe mean (see attachment, from geo-solutions page),
    that the 'pennant' (little triangle flag) should be FILLED and not
    only having an outline?

    Second 'issue' then is as Russ says: WHEN should you exactly start
    showing the 'pennant': at 50 or 48 knots...

    Is https://tephi.readthedocs.io/en/latest/barbs.html
    <https://tephi.readthedocs.io/en/latest/barbs.html> an
    authorative/canonical source? Or are there several and geotools
    just used another 'standard' :-)

    Regards,

    Richard Duivenvoorde


    On 3/11/21 10:50 AM, Russ Hore wrote:
    > I suspect this is the problem;
    >
    >
    
https://github.com/geotools/geotools/blob/872b44c28bb55f1e301bb607d53d431826ab7e78/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L229
    
<https://github.com/geotools/geotools/blob/872b44c28bb55f1e301bb607d53d431826ab7e78/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L229>
    
<https://github.com/geotools/geotools/blob/872b44c28bb55f1e301bb607d53d431826ab7e78/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L229
    
<https://github.com/geotools/geotools/blob/872b44c28bb55f1e301bb607d53d431826ab7e78/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L229>>
    >
    > If that was 47 I think you will get a filled pennant
    >
    > That is assuming this diagram is officially correct;
    > https://tephi.readthedocs.io/en/latest/barbs.html
    <https://tephi.readthedocs.io/en/latest/barbs.html>
    <https://tephi.readthedocs.io/en/latest/barbs.html
    <https://tephi.readthedocs.io/en/latest/barbs.html>>
    >
    > Russ
    >
    >> On 11 Mar 2021, at 09:04, Daniele Romagnoli
    <daniele.romagn...@geo-solutions.it
    <mailto:daniele.romagn...@geo-solutions.it>
    <mailto:daniele.romagn...@geo-solutions.it
    <mailto:daniele.romagn...@geo-solutions.it>>> wrote:
    >>
    >> Right,
    >> and the piece of code doing the build of the pennant is right
    there:
    >>
    
https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L358
    
<https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L358>
    
<https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L358
    
<https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs/WindBarb.java#L358>>
    >>
    >> Regards,
    >> Daniele
    >>
    >>
    >> On Thu, Mar 11, 2021 at 2:37 AM <br...@frogmouth.net
    <mailto:br...@frogmouth.net> <mailto:br...@frogmouth.net
    <mailto:br...@frogmouth.net>>> wrote:
    >>
    >>     The windbarb rendering code is in geotools.
    >>
    >>
    
https://github.com/geotools/geotools/tree/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs
    
<https://github.com/geotools/geotools/tree/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs>
    
<https://github.com/geotools/geotools/tree/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs
    
<https://github.com/geotools/geotools/tree/main/modules/library/render/src/main/java/org/geotools/renderer/style/windbarbs>>
    >>
    >>     You may be able to add a custom symbol using normal
    GeoServer styling, but the code approach is likely easier and better.
    >>
    >>     Brad.
    >>
    >>     On 11 Mar 2021 4:20 am, Niklas Elelid
    <geoserverl...@neware.se <mailto:geoserverl...@neware.se>
    <mailto:geoserverl...@neware.se <mailto:geoserverl...@neware.se>>>
    wrote:
    >>
    >>         Following the instructions in the GeoServer docs I have
    added the style windbarbs to my layer.
    >>
    >>
    >>
    
https://geoserver.geo-solutions.it/educational/en/multidim/accessing_multidim/rtx/wind_barbs.html
    
<https://geoserver.geo-solutions.it/educational/en/multidim/accessing_multidim/rtx/wind_barbs.html>
    
<https://geoserver.geo-solutions.it/educational/en/multidim/accessing_multidim/rtx/wind_barbs.html
    
<https://geoserver.geo-solutions.it/educational/en/multidim/accessing_multidim/rtx/wind_barbs.html>>
    >>
    >>
    >>         The flag in a windbarb symbolizing 50kts wind should be
    filled. I have been trying to find how the well known windbarb is
    built (and possibly can be changed) in GeoServer but have had no
    luck. Anyone has any good suggestions?
    >>
    >>
    >>         Thanks!
    >>
    >>
    >>         Niklas
    >>
    >>
    >>     _______________________________________________
    >>     Geoserver-users mailing list
    >>
    >>     Please make sure you read the following two resources
    before posting to this list:
    >>     - Earning your support instead of buying it, but Ian
    Turton: http://www.ianturton.com/talks/foss4g.html#/
    <http://www.ianturton.com/talks/foss4g.html#/>
    <http://www.ianturton.com/talks/foss4g.html#/
    <http://www.ianturton.com/talks/foss4g.html#/>>
    >>     - The GeoServer user list posting guidelines:
    http://geoserver.org/comm/userlist-guidelines.html
    <http://geoserver.org/comm/userlist-guidelines.html>
    <http://geoserver.org/comm/userlist-guidelines.html
    <http://geoserver.org/comm/userlist-guidelines.html>>
    >>
    >>     If you want to request a feature or an improvement, also
    see this:
    
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer>
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer>>
    >>
    >>
    >> Geoserver-users@lists.sourceforge.net
    <mailto:Geoserver-users@lists.sourceforge.net>
    <mailto:Geoserver-users@lists.sourceforge.net
    <mailto:Geoserver-users@lists.sourceforge.net>>
    >> https://lists.sourceforge.net/lists/listinfo/geoserver-users
    <https://lists.sourceforge.net/lists/listinfo/geoserver-users>
    <https://lists.sourceforge.net/lists/listinfo/geoserver-users
    <https://lists.sourceforge.net/lists/listinfo/geoserver-users>>
    >>
    >>
    >>
    >> --
    >> Regards,
    >> Daniele Romagnoli
    >> ==
    >> GeoServer Professional Services from the experts! Visit
    http://goo.gl/it488V <http://goo.gl/it488V> <http://goo.gl/it488V
    <http://goo.gl/it488V>> for more information.
    >> ==
    >>
    >> Ing. Daniele Romagnoli
    >> Senior Software Engineer
    >>
    >> GeoSolutions S.A.S.
    >> Via di Montramito 3/A
    >> 55054  Massarosa (LU)
    >> Italy
    >> phone: +39 0584 962313
    >> fax:      +39 0584 1660272
    >>
    >> http://www.geo-solutions.it <http://www.geo-solutions.it>
    <http://www.geo-solutions.it/ <http://www.geo-solutions.it/>>
    >> http://twitter.com/geosolutions_it
    <http://twitter.com/geosolutions_it>
    <http://twitter.com/geosolutions_it
    <http://twitter.com/geosolutions_it>>
    >>
    >> -------------------------------------------------------
    >>
    >> Con riferimento alla normativa sul trattamento dei dati
    personali (Reg. UE 2016/679 - Regolamento generale sulla
    protezione dei dati “GDPR”), si precisa che ogni circostanza
    inerente alla presente email (il suo contenuto, gli eventuali
    allegati, etc.) è un dato la cui conoscenza è riservata al/i
    solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le
    è giunto per errore, è tenuta/o a cancellarlo, ogni altra
    operazione è illecita. Le sarei comunque grato se potesse darmene
    notizia.
    >>
    >> This email is intended only for the person or entity to which
    it is addressed and may contain information that is privileged,
    confidential or otherwise protected from disclosure. We remind
    that - as provided by European Regulation 2016/679 “GDPR” -
    copying, dissemination or use of this e-mail or the information
    herein by anyone other than the intended recipient is prohibited.
    If you have received this email by mistake, please notify us
    immediately by telephone or e-mail.
    >> _______________________________________________
    >> Geoserver-users mailing list
    >>
    >> Please make sure you read the following two resources before
    posting to this list:
    >> - Earning your support instead of buying it, but Ian Turton:
    http://www.ianturton.com/talks/foss4g.html#/
    <http://www.ianturton.com/talks/foss4g.html#/>
    <http://www.ianturton.com/talks/foss4g.html#/
    <http://www.ianturton.com/talks/foss4g.html#/>>
    >> - The GeoServer user list posting guidelines:
    http://geoserver.org/comm/userlist-guidelines.html
    <http://geoserver.org/comm/userlist-guidelines.html>
    <http://geoserver.org/comm/userlist-guidelines.html
    <http://geoserver.org/comm/userlist-guidelines.html>>
    >>
    >> If you want to request a feature or an improvement, also see
    this:
    
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer>
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer>>
    >>
    >>
    >> Geoserver-users@lists.sourceforge.net
    <mailto:Geoserver-users@lists.sourceforge.net>
    <mailto:Geoserver-users@lists.sourceforge.net
    <mailto:Geoserver-users@lists.sourceforge.net>>
    >> https://lists.sourceforge.net/lists/listinfo/geoserver-users
    <https://lists.sourceforge.net/lists/listinfo/geoserver-users>
    >
    >
    >
    > _______________________________________________
    > Geoserver-users mailing list
    >
    > Please make sure you read the following two resources before
    posting to this list:
    > - Earning your support instead of buying it, but Ian Turton:
    http://www.ianturton.com/talks/foss4g.html#/
    <http://www.ianturton.com/talks/foss4g.html#/>
    > - The GeoServer user list posting guidelines:
    http://geoserver.org/comm/userlist-guidelines.html
    <http://geoserver.org/comm/userlist-guidelines.html>
    >
    > If you want to request a feature or an improvement, also see
    this:
    
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
    
<https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer>
    >
    >
    > Geoserver-users@lists.sourceforge.net
    <mailto:Geoserver-users@lists.sourceforge.net>
    > https://lists.sourceforge.net/lists/listinfo/geoserver-users
    <https://lists.sourceforge.net/lists/listinfo/geoserver-users>
    >



--
Regards,
Daniele Romagnoli
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V <http://goo.gl/it488V> for more information.
==

Ing. Daniele Romagnoli
Senior Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

http://www.geo-solutions.it <http://www.geo-solutions.it>
http://twitter.com/geosolutions_it <http://twitter.com/geosolutions_it>

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.


_______________________________________________
Geoserver-users mailing list

Please make sure you read the following two resources before posting to this 
list:
- Earning your support instead of buying it, but Ian Turton: 
http://www.ianturton.com/talks/foss4g.html#/
- The GeoServer user list posting guidelines: 
http://geoserver.org/comm/userlist-guidelines.html

If you want to request a feature or an improvement, also see this: 
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer


Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Reply via email to