Hello Simone
Thanks a lot for all your work with the merge. I will looks at them :).
There is some minor changes I did:
GeneralDirectPosition:
- Since the 'toString(DirectPosition)' convenience method has
been made public, we need to add a "@since 2.3" javadoc tag.
JTS:
- Added a "@since 2.3" javadoc tag.
- Added javadoc description for parameters.
- Localized some error message.
- Also, I took the liberty to replace the sentence "This method
is responsible for converting ..." by "Converts ...", which is
the kind of comment that Sun usually write in their javadoc. I
hope it is okay?
Comments about the new JTS.getEnvelope2D method:
- When an argument is explicitly checked for null value, Sun API usually
thrown
an IllegalArgumentException instead of a NullPointerException. Should we
do the
same?
- This method should probably thrown an MismatchedDimensionException instead
of
an TransformException (with a try ... catch ... rethrown).
Do you agree if I make the changes?
Other proposed changes (will wait for your okay) in the Errors.properties file:
CANT_SCALE_$1 should be renamed NONINVERTIBLE_SCALING_TRANSFORM
CANT_CROP_$1 should be renamed NULL_PARAMETER_$2
CANT_CROP_$2 should be renamed MISMATCHED_CROP_CRS
CANT_CROP_$3 should be renamed CANT_CROP
The digit after the '$' sign is not a sequential number, but is a remainder of
the number of
arguments expected by this localized message. For example "CANT_CROP" expect no
argument, while
"NULL_PARAMETER_$2" expect 2 arguments (the message is "{0}" parameter should
be not nul and of type
"{1}"). I admit that this is not documented in the developper guide...
By the way, feel free to start an "Errors_it.properties" file if you wish :).
Same for other
properties files of course.
Can I make the above changes?
Martin.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
