Hi Saul, Yes, you are correct, and this interface was indeed just recently added to geoapi. Unfortunately the fix requires a change to geoapi FilterVisitor. Which brings us to another issue.
Geootols 2.3.x seems to build against geoapi 2.1-M1 which from what I can tell has no tag in the geoapi repository. I am to blame for this, I must have forgotten to do this when i made the geoapi release. Unfortunately there have been some recent geoapi changes which would break geotools 2.3.x, so moving 2.3.x to geoapi trunk isn't really an option. So... to make a long story short here is what we have two options. Option 1: Create a geoapi 2.1-M1 tag, and roll back the recent changes from trunk, then apply the patch to fix the PropertyIsNotEqualTo. Option 2: Fix on geoapi trunk and geotools trunk and wait for 2.4 to pick up the fix. If this is a crucial fix for you Saul I can make some time this week to apply the fix via option 1. Regardless i have thrown together a jira bug for it. http://jira.codehaus.org/browse/GEOT-1021 -Justin Saul Farber wrote: > Hey geotools wizards, > > I was recently setting up some examples for some users of our new 1.5.x > based geoserver install, and came across an example that used to work, > but no longer does. > > It was an SLD layer with a UserStyle with a filter like: > > <Filter xmlns="http://www.opengis.net/ogc";> > <And> > <PropertyIsNotEqualTo> > <PropertyName>COUNTY</PropertyName> > <Literal>BARNSTABLE</Literal> > </PropertyIsNotEqualTo> > <PropertyIsNotEqualTo> > <PropertyName>COUNTY</PropertyName> > <Literal>MIDDLESEX</Literal> > </PropertyIsNotEqualTo> > </And> > </Filter> > > Unfortunately it didn't work. > > I think the culprit is that IsNotEqualToImpl throws an > UnsupportedOperationException in its accept() method, because > org.opengis.filter.FilterVisitor doesn't have a > visit(PropertyIsNotEqualTo,Object) method. > > Is this an oversight, or is there some specification-based reason why > PropertyIsNotEqualTo is omitted from the geoapi snapshot? > > There's even a note in the code from Justin saying something like, "Do > we need a PropertyIsNotEqualTo interface?" > > It's worth noting that PropertyIsNotEqualTo is an extraneous operation, > as you can re-write any "PropertyIsNotEqualTo" as a > "Not->PropertyIsEqualTo". Of course, by this logic, "Or" is likewise > extraneous as NAND gives you the complete space of boolean logic, right? > > > I can re-write the Filter XML -> internal rep parser to generate > "NOT->PropertyIsEqualTo" constructs, rather than using the > PropertyIsNotEqualTo construct, but this seems like a lot of work if > it's an oversight. > > > Any chance a new version of geoapi that fixes this is out there > somewhere and that someone might be committing it to gt-2.3.x anytime soon? > > > Thanks all! > --saul > > ------------------------------------------------------------------------- > SF.net email is sponsored by: A Better Job is Waiting for You - Find it Now. > Check out Slashdot's new job board. Browse through tons of technical jobs > posted by companies looking to hire people just like you. > http://jobs.slashdot.org/ > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:1004,455a0b9985021116498154! > -- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
