We have had some problems with Jalopy (mostly line feed handling on different platforms) - as such Ben and Andrea had me take it out of the developers guide.
I have included eclipse codeformatter and template instructions - do you use eclipse? If you are using NetBeans can I ask you to follow the instructions on the coding conventions page and email me the netbeans configuration information (or worst case we can take some screen snaps of how to configure it for the developers guide). Andrea was very clear that I needed to remind people not to format code once branches and tags have been made - it makes it very difficult to merge patches and fixes around. You can kind of get away with it if you do the formatting as a separate commit. Martin in the past has also been clear that code formatting is not always pretty; it is nice to line up options in an if statement for example. Finally (just for fun) I would urge you to run FindBugs on your code (we early recommended the tool PMD, but now Findbugs is a credible alternative). It always finds stupid mistakes for me; and is good at checking naming conventions and other stuff. Landon I have devoted two timeslots to geotools volunteer work; I would be happy to review your module next week (please choose the time slot you can attend and email me which one so I can plan my hacking). Jody PS. Congratulations on your hard work; I have run into customers in the field that are already looking at your code and considering its use (and retiring their internal code). I urged them to collaborate with you but so far they have been too shy. Sunburned Surveyor wrote: > I think I've got an "unsupported module" put together for my GPX2 > code. The last thing I have to do today is format the source code to > GeoTools standards using Jallopy. I'm going to try to do this today at > lunch. > > Would someone have a few minutes to review my module set-up next week > before I try to get it "officially" included in GeoTools? > > Thanks, > > Landon > > ------------------------------------------------------------------------------ > Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) > software. With Adobe AIR, Ajax developers can use existing skills and code to > build responsive, highly engaging applications that combine the power of local > resources and data with the reach of the web. Download the Adobe AIR SDK and > Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
