Jody Garnett ha scritto: > I agree; thanks for getting the answers from his semi-thawed state. The > use of test dependencies is new to the code base and caused me trouble > when releasing recently.
Well, not exactly new, the first usage of it dates back to the postgis versioning module tests depending on the postgis ones, which is two years old. If you know any way to have unit test classes be run and be reused (by subclassing) in other modules then I'm all ears. I need them in order to check the versioning extension is working transparently, that is, passes the same tests as the original postgis datastore. I could copy the whole test code from one datastore to the other, which would duplicate maintenance a lot... jdbc-ng works in a similar way, but the test classes could be split into their own module if we want to, since they are an abstract test suite that needs subclassing in order to run at all. > I am not quite sure how they are being handled; > is this a new feature of maven? Nope, been there for years. Also the maven surefire guide itself speaks against using -Dmaven.test.skip=true and suggests the usage of -DskipTests instead: http://maven.apache.org/plugins/maven-surefire-plugin/examples/skipping-test.html See also: http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html "skip Set this to 'true' to bypass unit tests entirely. Its use is NOT RECOMMENDED, especially if you enable it using the "maven.test.skip" property, because maven.test.skip disables both running the tests and compiling the tests. Consider using the skipTests parameter instead. " I'm open to code reworks if everybody feels against them, but it seems to me we achieve a better result by just following Maven recommendation and update the dev guide accordingly? Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
