Gabriel Roldan ha scritto: > Hi Andrea, this looks alright to me, including the patch. > It's just that the term "existing feature id" strikes me to think the > feature id exists somewhere else, when the actual purpose is to use the > "user provided feature id"? > What if we rephrase it so that isUseExisingFIDSupported becomes > isUserProvidedFIDSupported, etc? That way would be less confusing imho.
I took the terminology from the WFS standard: http://schemas.opengis.net/wfs/1.1.0/wfs.xsd In particular: <xsd:simpleType name="IdentifierGenerationOptionType"> <xsd:restriction base="xsd:string"> <xsd:enumeration value="UseExisting"> <xsd:annotation> <xsd:documentation> The UseExsiting value indicates that WFS should not generate a new feature identifier for the feature being inserted into the repositry. Instead, the WFS should use the identifier encoded if the feature. If a duplicate exists then the WFS should raise an exception. </xsd:documentation> .... </xsd:simpleType> User provided would make me think the id has to provided "out of band", that is, somewhere else other than in the feature. Anyways, I don't feel strongly one way or the other, if the other developer feel that "user provided" is better I'll make the change, no problem :-) Cheers Anrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
