Hi Michael reviewing now:
> I've just gone through the library modules, attempting to track down
> all instances of Geometry.equals( Geometry ) and changing them to one
> of: equalsExact, equalsTopo or, getAttribute was involved, just
> removing the cast from Object to Geometry.
Sounds great.
> It's a tad unfortunate that Geometry.equals( Geometry ) is a
> non-deprecated synonym for equalsTopo since that is computationally
> expensive.
I thought he was going to deprecate that?
> I've done a new patch rather than committing because there are quite a
> few extra changes. Could you review it please ?
> https://jira.codehaus.org/browse/GEOT-3406
Reviewing now (thanks to aaime for fixing the build BTW). So far the only thing
I want to do is turn the following blog post into a page for the docs:
- http://how2map.blogspot.com/2011/02/equals-vs-equals-vs-equals-exact.html
> One particular bit to check: in
> org.geotools.feature.FeatureTypeTest.testDeepCopy I deleted the three
> asserts comparing point objects because they seemed, er, pointless.
>
> The new patch is library-jts-1.12.patch (there is a single change to the cql
> module with the rest being in main).
Will add my review to the JIRA.
Would you like to commit this when you get a chance tomorrow?
I am thinking it would be nice to a M1 release with the latest JTS 1.12 and
Java 6 (not sure where we are - it seems like Andrea got the testing sorted out
over the weekend).
Jody
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
