Thanks Justin; I noted this a while back (and put in the warnings so we
could try and detect what was going on). I think we could remove one of the
area functions; as they both do the same thing (and less code is good).
We also have not managed to make good on your FunctionName changes yet; only
about 50% of the functions have been updated. Are you going to have any
capacity to do the rest? Or would you like to set up a work party ...
Jody
On Fri, Aug 5, 2011 at 3:27 AM, Justin Deoliveira <[email protected]>wrote:
> Hi all,
>
> I have recently noticed some warnings that commit from
> DefaultFunctionFactory:
>
> Aug 4, 2011 11:19:46 AM org.geotools.filter.function.DefaultFunctionFactory
> loadFunctions
> WARNING: Function in10 clash between FilterFunction_in9 and
> FilterFunction_in10
> Aug 4, 2011 11:19:46 AM org.geotools.filter.function.DefaultFunctionFactory
> getFunctionName
> WARNING: class
> org.geotools.filter.function.FilterFunction_bufferWithSegments has name
> conflict betwee 'bufferWithSegments' and 'buffer'
> Aug 4, 2011 11:19:46 AM org.geotools.filter.function.DefaultFunctionFactory
> loadFunctions
> WARNING: Function area clash between FilterFunction_area and AreaFunction
> Aug 4, 2011 11:19:46 AM org.geotools.filter.function.DefaultFunctionFactory
> loadFunctions
> WARNING: Function in10 clash between FilterFunction_in10 and
> FilterFunction_in8
>
> that seem to point to name clashes. Upon inspection it seems there are some
> typos.
>
> 1. in8 and in9 declare the name "in10"
> 2. bufferWithSegments declares the name "buffer"
> 3. there are two area functions... one "Area" and one "area"
>
> I believe (1) and (2) are just copy and paste errors. However three though
> is legitimate. The conflict occurs because we actually convert the names to
> lowercase when storing them in the lookup map. Reason being to be a bit lax
> when users specify functions and don't get the case exactly write (which
> isn't consistent across functions... some all lower case, some camel case,
> etc...)
>
> So... to fix (3) what about naming "Area" to "area2" or something?
>
> Thoughts?
>
> -Justin
>
> ps. If you are wondering why I want to get rid of the warnings it is
> because i am executing via geoscript, and such warnings are somewhat
> annoying when executing via a REPL :)
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
>
>
> ------------------------------------------------------------------------------
> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
