What I did was open up the type hierarchy in Eclipse and go through everything
that extended function. I think now that I have done that 1st pass (to get
"names" in there) you could do the same thing with the FunctionNameImpl
constructor - look for all occurrences in the code and check them - I think you
had a nice utility method in a super class; so is easy to sort out "progress".
Where we got stuck; and where I stopped was with the discussion around handling
variable length parameters such as interpolate. I put some of the discussion
into the wiki page; but I don't recall us sorting that out and moving on.
Cheers
--
Jody Garnett
On Saturday, 6 August 2011 at 12:30 AM, Justin Deoliveira wrote:
> I will try to put in a shift over the weekend to update functions. Any
> advice? Did you get to a certain point?
>
> On Thu, Aug 4, 2011 at 6:34 PM, Jody Garnett <jody.garn...@gmail.com
> (mailto:jody.garn...@gmail.com)> wrote:
> > Thanks Justin; I noted this a while back (and put in the warnings so we
> > could try and detect what was going on). I think we could remove one of the
> > area functions; as they both do the same thing (and less code is good).
> >
> > We also have not managed to make good on your FunctionName changes yet;
> > only about 50% of the functions have been updated. Are you going to have
> > any capacity to do the rest? Or would you like to set up a work party ...
> >
> > Jody
> >
> >
> > On Fri, Aug 5, 2011 at 3:27 AM, Justin Deoliveira <jdeol...@opengeo.org
> > (mailto:jdeol...@opengeo.org)> wrote:
> > > Hi all,
> > >
> > > I have recently noticed some warnings that commit from
> > > DefaultFunctionFactory:
> > >
> > > Aug 4, 2011 11:19:46 AM
> > > org.geotools.filter.function.DefaultFunctionFactory loadFunctions
> > > WARNING: Function in10 clash between FilterFunction_in9 and
> > > FilterFunction_in10
> > > Aug 4, 2011 11:19:46 AM
> > > org.geotools.filter.function.DefaultFunctionFactory getFunctionName
> > > WARNING: class
> > > org.geotools.filter.function.FilterFunction_bufferWithSegments has name
> > > conflict betwee 'bufferWithSegments' and 'buffer'
> > > Aug 4, 2011 11:19:46 AM
> > > org.geotools.filter.function.DefaultFunctionFactory loadFunctions
> > > WARNING: Function area clash between FilterFunction_area and AreaFunction
> > > Aug 4, 2011 11:19:46 AM
> > > org.geotools.filter.function.DefaultFunctionFactory loadFunctions
> > > WARNING: Function in10 clash between FilterFunction_in10 and
> > > FilterFunction_in8
> > >
> > > that seem to point to name clashes. Upon inspection it seems there are
> > > some typos.
> > >
> > > 1. in8 and in9 declare the name "in10"
> > > 2. bufferWithSegments declares the name "buffer"
> > > 3. there are two area functions... one "Area" and one "area"
> > >
> > > I believe (1) and (2) are just copy and paste errors. However three
> > > though is legitimate. The conflict occurs because we actually convert the
> > > names to lowercase when storing them in the lookup map. Reason being to
> > > be a bit lax when users specify functions and don't get the case exactly
> > > write (which isn't consistent across functions... some all lower case,
> > > some camel case, etc...)
> > >
> > > So... to fix (3) what about naming "Area" to "area2" or something?
> > >
> > > Thoughts?
> > >
> > > -Justin
> > >
> > > ps. If you are wondering why I want to get rid of the warnings it is
> > > because i am executing via geoscript, and such warnings are somewhat
> > > annoying when executing via a REPL :)
> > > --
> > > Justin Deoliveira
> > > OpenGeo - http://opengeo.org
> > > Enterprise support for open source geospatial.
> > >
> > >
> > > ------------------------------------------------------------------------------
> > > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
> > > The must-attend event for mobile developers. Connect with experts.
> > > Get tools for creating Super Apps. See the latest technologies.
> > > Sessions, hands-on labs, demos & much more. Register early & save!
> > > http://p.sf.net/sfu/rim-blackberry-1
> > > _______________________________________________
> > > Geotools-devel mailing list
> > > Geotools-devel@lists.sourceforge.net
> > > (mailto:Geotools-devel@lists.sourceforge.net)
> > > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> > >
> >
>
>
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
