On Fri, Aug 5, 2011 at 7:17 AM, Jody Garnett <jody.garn...@gmail.com> wrote:

>  I was actually hoping for Gabriel's viewpoint as maintainer of ArcSDE
> which supports versioned tables (for the 3rd viewpoint).
>
> I don't really mind about the names; I think those other classes you
> mention are "internal" and the FeatureSource / FeatureStore interfaces are
> more common (and thus less surprising) for api work.
>
> Do you think we can get away with one interface?
>

I don't believe we can, when working with security you can have users that
are only allowed to
read, either because of higher level security or database level security,
the customary way
to tell read only and writable in GeoTools is to have the object implement
either FeatureSource
or FeatureStore.
If you want to change the library conventions you can go through the
proposal process and then
change all of the library to follow suite. I just don't want to have yet
another inconsistency around.

The original names were associated to interfaces that were meant to be
published in
main once the work stabilized, there was nothing "internal" about them, I
just did not push
them into core because we missed the other two implementations to vet them.
http://svn.osgeo.org/geotools/trunk/modules/unsupported/postgis-versioned/src/main/java/org/geotools/data/VersioningDataStore.java
http://svn.osgeo.org/geotools/trunk/modules/unsupported/postgis-versioned/src/main/java/org/geotools/data/VersioningFeatureStore.java
http://svn.osgeo.org/geotools/trunk/modules/unsupported/postgis-versioned/src/main/java/org/geotools/data/VersioningFeatureSource.java

GeoServer WFS-V and GSS modules explicitly work with these interfaces, and
in GeoServer core there
is a dynamic check for their names using the class name, see here:
http://svn.codehaus.org/geoserver/trunk/src/main/src/main/java/org/geoserver/catalog/ResourcePool.java
and search for "versioning" inside of it

Cheers
Andrea

-- 
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy

phone: +39 0584 962313
fax:      +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------
------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts. 
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to