On Sun, Apr 27, 2014 at 10:21 AM, Andrea Aime
<andrea.a...@geo-solutions.it>wrote:
> Hi,
> so the windows build also fails here, with 380 and 771 pixels of difference
> respectively.
>
> Instead of starting to set different limits, I'd just raise the limit to
> 1200 for both
> tests and call it a day.
>
> The bug that I've fixed when that test was created would have created
> something
> like 10-20k pixels of difference, as the labels and the shield below it
> were either
> missing completely (one of them) or moved 100 pixels below (the other one)
>
> Jody, is this the only failure you have?
>
I've updated the branch loosening the number of pixels to be checked in
those tests to 1200
and making another fix (the code was writing a sample image in /tmp/), and
the build works fine.
Maybe the assertions should be re-worked so that they are expressed in
terms of percentages?
1200 seems like a big number, but percentage wise on that image, it's 1.3%
of the pixels.
Maybe an assertion like:
ImageAssert.assertEquals(image1, image2, 0.013);
would look better?
Cheers
Andrea
--
==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
