That is the only failure I have.
Jody Garnett
On Sun, Apr 27, 2014 at 6:21 PM, Andrea Aime
<andrea.a...@geo-solutions.it>wrote:
> Hi,
> so the windows build also fails here, with 380 and 771 pixels of difference
> respectively.
>
> Instead of starting to set different limits, I'd just raise the limit to
> 1200 for both
> tests and call it a day.
>
> The bug that I've fixed when that test was created would have created
> something
> like 10-20k pixels of difference, as the labels and the shield below it
> were either
> missing completely (one of them) or moved 100 pixels below (the other one)
>
> Jody, is this the only failure you have?
>
> Cheers
> Andrea
>
>
>
>
> On Sun, Apr 27, 2014 at 9:36 AM, Jody Garnett <jody.garn...@gmail.com>wrote:
>
>> I would also be happy with a higher threshold, but was not sure if you
>> would be - since often that 1% is what we are actually testing is correct.
>>
>> Still you can use the os and version logic to set this combined with the
>> value from the original email:
>> * testLabelShieldMultiline: 1100
>> * testLabelShieldMultilineStretch: 1200
>>
>>
>>
>> Jody Garnett
>>
>>
>> On Sun, Apr 27, 2014 at 5:04 PM, Andrea Aime <
>> andrea.a...@geo-solutions.it> wrote:
>>
>>> On Sun, Apr 27, 2014 at 8:39 AM, Jody Garnett <jody.garn...@gmail.com>wrote:
>>>
>>>> 4) OSX 10.9 Reference Images
>>>>
>>>> Since this is a known JDK bug I do not want to put a great deal of
>>>> effort into a workaround, I recommend carrying additional "osx" references
>>>> images in or codebase until it is resolved.
>>>>
>>>> I was unable to directly do a pull request against your repository
>>>> andrea, if you want cherry-pick the commit here it is:
>>>>
>>>>
>>>> https://github.com/jodygarnett/geotools/commit/591591db05d623affd9a0e847898c00d99b6fef6
>>>>
>>>
>>> I see where you're going, it worries me a bit... in terms of, how stable
>>> is this, compared to java version changes in
>>> OSX?
>>> And if we start going down this path, who is going to maintain the OSX
>>> version? What if we find that Windows
>>> needs its own set of images too, do we need someone to maintain Windows
>>> samples too?
>>>
>>> I am wondering if we would not be better off just setting a
>>> significantly higher threshold for tests that involve
>>> labels. After all 1000 pixels difference is just 1% difference in a
>>> 300x300 image
>>>
>>> Cheers
>>> Andrea
>>>
>>>
>>> --
>>> ==
>>> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
>>> for more information.
>>> ==
>>>
>>> Ing. Andrea Aime
>>> @geowolf
>>> Technical Lead
>>>
>>> GeoSolutions S.A.S.
>>> Via Poggio alle Viti 1187
>>> 55054 Massarosa (LU)
>>> Italy
>>> phone: +39 0584 962313
>>> fax: +39 0584 1660272
>>> mob: +39 339 8844549
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> -------------------------------------------------------
>>>
>>
>>
>
>
> --
> ==
> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
