Hi,
I prepared a pull request for the subject:
https://github.com/geotools/geotools/pull/470
I used tha approach described in my last email.
As an additional note, I also added a preserveOrder flag to help pagination
be consistent.
With this flag the visitor set mantains the order in which items have been
inserted, so the elements are consistently ordered between each visitor
call.
Regards,
Mauro Bartolomeoli
2014-05-30 19:07 GMT+02:00 Andrea Aime <andrea.a...@geo-solutions.it>:
> On Fri, May 30, 2014 at 6:58 PM, Mauro Bartolomeoli <
> mauro.bartolome...@geo-solutions.it> wrote:
>
>> Hi,
>> moving on on this, I tried the following approach:
>> - created a new LimitingVisitor interface with getStartIndex and
>> getMaxFeatures methods, to be used by visitor aware stores
>> - changed UniqueVisitor to implement this interface and added pagination
>> capabilities to the visitor if those two properties are defined (this will
>> handle stores that are not visitor aware)
>> - made JDBCDataStore aware of LimitingVisitor, using it to get limits in
>> aggregated queries, if limits are defined in Visitor instead that in Query
>>
>> This way, the old behaviour is mantained if limits are defined in Query,
>> the new one (limits applied after aggregation) if they are defined in the
>> visitor.
>>
>> What do you think?
>> Can I move forward with it?
>>
>
> Seems a good approach to me, would be nice to hear from the other core
> devs (thinking Christian, Justin as jdbc module co-maintainer,
> and Jody since he designed the visitors in the first place, but of course
> anybody is warmly welcomed to provide feedback)
>
> Cheers
> Andrea
>
> --
> ==
> Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
