Thanks, Rini.

I think I found the problem: there is an unwanted @Override in 
org.geotools.gml3.bindings.ext.CurvePropertyTypeBinding that prematurely 
returns the geometry object before the superclass has a chance to 
recognise that it should be nulled out because there is an xlink:href.

I will test with a full build.

Kind regards,
Ben.

On 15/07/14 14:11, Angreani, Rini (Mineral Resources, Kensington) wrote:
> It's also done in gml2/GMLEncodingUtils.GeometryPropertyType_getProperty.
>
> Cheers
> Rini
>
> -----Original Message-----
> From: Caradoc-Davies, Ben (Mineral Resources, Kensington)
> Sent: Tuesday, 15 July 2014 12:25 PM
> To: Andrea Aime
> Cc: Geotools-Devel list; Angreani, Rini (Mineral Resources, Kensington)
> Subject: Re: [Geotools-devel] App-schema, xlinks, and curves
>
> Andrea,
>
> I am investigating now. My understanding is that the correct behaviour is to 
> encode no content as this property is being mapped by reference.
> The handling of automatic (duplicate id) href is in 
> ComplexSupportXSAnyTypeBinding and its neighbours, but there may be 
> assumptions based on the behaviour of other bindings. Content is suppressed 
> by setting the children to an empty container. I will have to check to see 
> where mapped href is set differently and what changes there are to the 
> geometry bindings.
>
> Kind regards,
> Ben.
>
> On 11/07/14 18:51, Andrea Aime wrote:
>> Hi all,
>> the arcs pull request has been updated to handle GML encoding of arcs
>> (see the other mail about this topic for details).
>> Generally speaking it's working well, GeoServer builds also work fine
>> minus one hitch in the app-schema tests
>>
>> Basically, I have a xlink test failing on me,
>> XLinkGeometryTest.testGeometry, that ends up encoding something like
>> this:
>>
>> <ex:multisurface xlink:href="#geom10"/> <ex:multipolygon
>> xlink:href="#geom11"/> <ex:geometryref xlink:href="xlinkvalue1"/>
>> <ex:curveref xlink:href="xlinkvalue2"> <gml:LineString> <gml:posList/>
>> </gml:LineString> </ex:curveref> ...
>>
>> In other words, the other elements are empty, but curve is not.
>> However, I don't see where the href management is, and how it's
>> supposed to behave.
>> Looking at the results, it seems the encoder was fed with an empty
>> linestring...
>>
>> Do you have any quick pointers?
>>
>> Cheers
>> Andrea
>>
>> --
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/NWWaa2 for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054  Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39  339 8844549
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>>
>> ----------------------------------------------------------------------
>> -------- Open source business process management suite built on Java
>> and Eclipse Turn processes into business applications with Bonita BPM
>> Community Edition Quickly connect people, data, and systems into
>> organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards
>> http://p.sf.net/sfu/Bonitasoft
>>
>>
>>
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
> --
> Ben Caradoc-Davies <ben.caradoc-dav...@csiro.au> Software Engineer CSIRO 
> Mineral Resources Flagship Australian Resources Research Centre
>

-- 
Ben Caradoc-Davies <ben.caradoc-dav...@csiro.au>
Software Engineer
CSIRO Mineral Resources Flagship
Australian Resources Research Centre

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to