Hello Jody,

Thanks for working on my pull requests. I will look at all your remarks and answer/resolve shortly.

Sorry for the issue with the kml patch I approved. I read and checked all the code but in the future I will always make a local build as well before merging.

Regards
Niels

On 18-01-15 00:18, Jody Garnett wrote:
Thanks Sampo, it really helps having someone familiar with the codebase to provide a review. I will check it over for the usual glitches (headers, formatting) and look at including it today.

And thanks to Niels for the hustle getting these pull requests in time.

--
Jody Garnett

On 17 January 2015 at 04:09, Sampo Savolainen <sampo.savolai...@spatineo.com <mailto:sampo.savolai...@spatineo.com>> wrote:

    Hi,

    I rebuilt the war and the wfs-ng store registers just fine. I
    must've botched the earlier geoserver build I tried with.

    I'm giving this pull request my full hearted support for inclusion
    into GeoTools 13.


     Sampo


     Sampo

    On Fri, Jan 16, 2015 at 6:36 PM, Sampo Savolainen
    <sampo.savolai...@spatineo.com
    <mailto:sampo.savolai...@spatineo.com>> wrote:

        Thats great news. So what about including this is 2.7?

        Btw. Niels, what maven commands do you use to produce the
        build? It sounds like I'm missing some options or something.

          Sampo

        On Jan 16, 2015 6:10 PM, "Niels Charlier" <ni...@scitus.be
        <mailto:ni...@scitus.be>> wrote:

            Sampo, it works for me in a tomcat. I think the issue must
            be with your setup.

            Regards
            Niels

            On 16-01-15 16:29, Niels Charlier wrote:

                I'll give it a try

                On 16-01-15 07:38, Sampo Savolainen wrote:

                    >Hi,
                    >
                    >This is weird: If I run GeoServer in eclipse
                    using the Start class in
                    >gs-web-app, the Capabilities is registered fine.
                    However, if I build the
                    >war and deploy it in tomcat, GeoServer cannot
                    register the schema. Is there
                    >any chance you have time to check this?
                    >
                    >
                    >   Sampo
                    >
                    >On Thu, Jan 15, 2015 at 9:03 PM, Niels
                    Charlier<ni...@scitus.be <mailto:ni...@scitus.be>>
                    wrote:
                    >

                        >>I have done so.
                        >>
                        >>Regards
                        >>Niels
                        >>
                        >>
                        >>On 15-01-15 18:21, Sampo Savolainen wrote:
                        >>

                            >>>Hi,
                            >>>
                            >>>Can you push the rebased branch so I
                            can test the exact same version?
                            >>>
                            >>>Sampo
                            >>>On Jan 15, 2015 5:37 PM, "Niels
                            Charlier"<ni...@scitus.be
                            <mailto:ni...@scitus.be>> wrote:
                            >>>
                            >>>   Hello Sampo,

                                >>>>I cannot reproduce this error. I
                                have rebased everything. I can use the
                                >>>>mentioned file to create a
                                datastore in geoserver.
                                >>>>
                                >>>>Regards,
                                >>>>Niels
                                >>>>
                                >>>>On 15-01-15 12:02, Sampo
                                Savolainen wrote:
                                >>>>
                                >>>>   Hi,

                                    >>>>>This should happen when
                                    adding a wfs-ng store using the
                                    mentioned test
                                    >>>>>GetCapabilities file. If it
                                    works for you, then I guess
                                    something goes
                                    >>>>>wrong when rebasing the branch.
                                    >>>>>
                                    >>>>>
                                    >>>>>     Sampo
                                    >>>>>
                                    >>>>>
                                    >>>>>
                                    >>>>>
                                    >>>>>On Thu, Jan 15, 2015 at 12:42
                                    PM, Niels Charlier<ni...@scitus.be
                                    <mailto:ni...@scitus.be>>
                                    >>>>>wrote:
                                    >>>>>
                                    >>>>> Hello Sampo,
                                    >>>>>

                                        >>>>>>Can you clarify how I
                                        can reproduce this problem, if
                                        it doesn't occur
                                        >>>>>>in
                                        >>>>>>the tests?
                                        >>>>>>
                                        >>>>>>Regards
                                        >>>>>>Niels
                                        >>>>>>
                                        >>>>>>
                                        >>>>>>On 15-01-15 10:59, Sampo
                                        Savolainen wrote:
                                        >>>>>>
                                        >>>>>>Hi,
                                        >>>>>>
                                        >>>>>>  Yeah, rebasing Niels's
                                        branch works.
                                        >>>>>>
                                        >>>>>>  Unfortunately
                                        something is broken with the
                                        schema bindings in this
                                        >>>>>>branch. I'm unable to
                                        register the FMI Capabilities
                                        document with
                                        >>>>>>GeoServer
                                        >>>>>>(see exception below).
                                        The funny thing is, that the
                                        gt-xsd-wfs unit
                                        >>>>>>test
                                        >>>>>>that parses this
                                        document works fine. I also
                                        tried adding a parsing
                                        >>>>>>test
                                        >>>>>>for it in gt-wfs-ng
                                        WFSClientTest.testInit_2_0()
                                        and that parses the





-- Sampo Savolainen
    R&D Director, Spatineo Oy
    sampo.savolai...@spatineo.com <mailto:sampo.savolai...@spatineo.com>
    +358-407555649 <tel:%2B358-407555649>
    Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
    www.spatineo.com <http://www.spatineo.com>,
    twitter.com/#!/spatineo <http://twitter.com/#%21/spatineo>
    www.linkedin.com/company/spatineo-inc
    <http://www.linkedin.com/company/spatineo-inc>

    This message may contain privileged and/or confidential
    information. If you
    have received this e-mail in error or are not the intended
    recipient, you
    may not use, copy, disseminate, or distribute it; do not open any
    attachments, delete it immediately from your system and notify the
    sender
    promptly by e-mail that you have done so.

    
------------------------------------------------------------------------------
    New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
    GigeNET is offering a free month of service with a new server in
    Ashburn.
    Choose from 2 high performing configs, both with 100TB of bandwidth.
    Higher redundancy.Lower latency.Increased capacity.Completely
    compliant.
    http://p.sf.net/sfu/gigenet
    _______________________________________________
    GeoTools-Devel mailing list
    GeoTools-Devel@lists.sourceforge.net
    <mailto:GeoTools-Devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/geotools-devel



------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to