Torben, I am not convinced that it is a good idea to rename 291 classes on the eve of an RC1 release. We are in a freeze, after all. This proposal certainly merits discussion.
Kind regards, Ben. On 18/02/15 14:29, Torben Barsballe wrote: > Here is a pull request that updates *all* classes inheriting from > OnlineTest to end in OnlineTest.java: > https://github.com/geotools/geotools/pull/742 > Hopefully this is still in time for RC1. > > Torben > > On Tue, Feb 17, 2015 at 2:47 PM, Torben Barsballe < > tbarsba...@boundlessgeo.com> wrote: > >> Renaming all database tests to end in OnlineTest is easy, and can get done >> in time for RC1. >> >> We should probably also look and see if there are other "Online" tests >> that should be renamed, but this will likely require a bit of digging and >> probably won't be ready for RC1. >> >> Torben >> >> On Tue, Feb 17, 2015 at 2:24 PM, Jody Garnett <jody.garn...@gmail.com> >> wrote: >> >>> Good research, that will be quite the pull request :) Can we get it done >>> in time for RC1? >>> >>> -- >>> Jody Garnett >>> >>> On 17 February 2015 at 14:07, Torben Barsballe < >>> tbarsba...@boundlessgeo.com> wrote: >>> >>>> I am working on getting online database tests set up and runing on >>>> ares/Jenkins. >>>> According to our documentation >>>> <http://docs.geotools.org/latest/userguide/build/maven/testing.html#online-testing>, >>>> any tests requiring an online resurce should end in OnlineTest.java, and >>>> will only run under the "-P online" maven profile. >>>> >>>> It turns out that all of our database tests do not follow this naming >>>> convention, and instead derive their name from the jdbc test class which >>>> they extend. >>>> >>>> This means that the database tests will run as long as you have the >>>> appropriate database fixture your ~/.geotools directory, completely >>>> independant of the maven "online" profile. >>>> >>>> In order to properly support enabling/disabling online tests, it seems >>>> like it will be necessary to append OnlineTest to the name of all tests >>>> which require online resources... >>>> >>>> Torben >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server >>>> from Actuate! Instantly Supercharge Your Business Reports and Dashboards >>>> with Interactivity, Sharing, Native Excel Exports, App Integration & more >>>> Get technology previously reserved for billion-dollar corporations, FREE >>>> >>>> http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk >>>> _______________________________________________ >>>> GeoTools-Devel mailing list >>>> GeoTools-Devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>> >>>> >>> >> > > > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk > > > > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Ben Caradoc-Davies <b...@transient.nz> Software Engineer Transient Software <http://transient.nz> New Zealand ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
