Freeze only applies to new features, so your bug fix should be fine.
Thanks for the background information; best of luck getting it in for the
2.12 release.
--
Jody Garnett
On 22 August 2017 at 12:42, Peter Kovac <peter.ko...@microstep-mis.com>
wrote:
> Hi Jody,
>
> our company is working on a fix for an issue I was discussing months ago
> on user list: https://sourceforge.net/p/geotools/mailman/message/35479331/
>
> The problem is that there is no possibility to have time information along
> with date when using Oracle database with ImageMosaic plugin. Andrea Aime
> suggested mapping java.sql.Timestamp to database TIMESTAMP type (in the
> OracleDialect class) to preserve backwards compatibility.
> The fix itself is trivial, it's just adding two lines of code:
> https://github.com/geotools/geotools/compare/master...
> MicroStep-MIS:oracle_timestamp
>
> I have manually verified that it solves my problem. We are now trying to
> figure out a reasonable test case (the change does not fail any existing
> tests) so we can file a JIRA issue and submit a pull request.
> Unfortunatelly, we are not very familiar with the project's code base yet,
> so it takes more time than I expected.
>
> We weren't aware of the code-freeze coming up so we took it slowly and not
> with high priority. Do you think it's a good idea to try to speed up things
> a bit and try to finish the PR this week?
>
> To be more specific about the test case: we are taking inspiration from
> the
> org.geotools.data.oracle.OracleDataStoreOnlineTest.testCreateSchemaOSGBCrs()
> test:
>
> 1) create a SimpleFeatureType with a java.sql.Timestamp attribute
> 2) create an Oracle JDBCDataStore and instert some data with some specific
> date and time to it
> 3) read from the datastore and verify that the time information is not
> chopped off
>
> I don't have any code right now since it's a colleague of mine who is
> responsible for coding it. I might post some code tomorrow if you agree
> that it's a good idea. Of cours, we welcome any advice in case we are
> missing something important.
>
> Regards,
>
> Peter Kovac,
> MicroStep-MIS
>
>
>
> On 22. 8. 2017 20:29, Jody Garnett wrote:
>
> Welcome back from foss4g, we have a GeoTools 18-beta release scheduled for
> this week,
>
> I would like to start the geotools release process on Saturday (this is a
> weekend activity) - please reply to this thread if you have any
> functionality or fix trying to sneak in under the wire.
>
> The beta release marks the start of our code freeze, during the code
> freeze we will not be accepting new functionality onto master - allowing
> the team to focus on bug fixes.
> --
> Jody Garnett
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> GeoTools-Devel mailing
> listGeoTools-Devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
> --
> Peter Kovac
> IMS Programmer
> microstep-mispeter.ko...@microstep-mis.com
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
