Hi Ben,
I've already inquired to Even about those failures, looks like signature of
a few methods changes in OGR 1.11.
Both JNI and BridJ bindings fail, the difference is that BridJ does not
need the "bridge" JNI native library so it
runs most of the time, while the JNI one skip the tests.
Now, with something dynamic as BridJ I guess one could check the OGR
version, have native bindings for
the various methods overloads, and call the right ones, but for the JNI
case I'm not sure what to do.
This notion of "buliding against a knows GDAL version" is not a match for
the way we do things, GeoTools/GeoServer
are just dropped on a machine and the find whatever they find, there is no
notion of packaging against a specific
version like with the native packages.
All in all I'm tempted to just drop support for the OGR data store, at
least of the BridJ part, it's getting too much
work to maintain and there are other things having a higher priority, and
to be honest, I have never used it
for a real project (I created the first version of it in my spare time as a
"good gesture" in the OSGeo familiy,
but never got traction).
Discussion with Even follows.
Cheers
Andrea
---------- Forwarded message ----------
From: Andrea Aime <andrea.a...@geo-solutions.it>
Date: Sun, Mar 18, 2018 at 4:27 PM
Subject: Binary incompatible change in OGR JNI?
To: Even Rouault <even.roua...@spatialys.com>
Hi Even,
recently I have had reports of some failures in the GeoTools bridge to OGR.
Looking into it I've found this build error:
Warning 1: Field name of width 255 truncated to 254.
Tests run: 27, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.882 sec
<<< FAILURE! - in org.geotools.data.ogr.jni.JniOGRDataStoreTest
testGeometryFilters(org.geotools.data.ogr.jni.JniOGRDataStoreTest) Time
elapsed: 0.014 sec <<< ERROR!
java.lang.UnsatisfiedLinkError: org.gdal.ogr.ogrJNI.Layer_
SetSpatialFilter(JLorg/gdal/ogr/Layer;JLorg/gdal/ogr/Geometry;)V
at org.gdal.ogr.ogrJNI.Layer_SetSpatialFilter(Native Method)
at org.gdal.ogr.Layer.SetSpatialFilter(Layer.java:89)
at org.geotools.data.ogr.jni.JniOGR.LayerSetSpatialFilter(JniOGR.java:257)
at org.geotools.data.ogr.OGRFeatureSource.setLayerFilters(
OGRFeatureSource.java:128)
at org.geotools.data.ogr.OGRFeatureSource.getCountInternal(
OGRFeatureSource.java:158)
at org.geotools.data.ogr.OGRFeatureStore.getCountInternal(
OGRFeatureStore.java:109)
at org.geotools.data.store.ContentFeatureSource.getCount(
ContentFeatureSource.java:507)
at org.geotools.data.store.ContentFeatureCollection.size(
ContentFeatureCollection.java:231)
at org.geotools.data.ogr.OGRDataStoreTest.testGeometryFilters(
OGRDataStoreTest.java:750)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at org.geotools.data.ogr.TestCaseSupport.run(TestCaseSupport.java:113)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at org.junit.internal.runners.JUnit38ClassRunner.run(
JUnit38ClassRunner.java:84)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(
JUnit4Provider.java:264)
at org.apache.maven.surefire.junit4.JUnit4Provider.
executeTestSet(JUnit4Provider.java:153)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(
JUnit4Provider.java:124)
at org.apache.maven.surefire.booter.ForkedBooter.
invokeProviderInSameClassLoader(ForkedBooter.java:200)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(
ForkedBooter.java:153)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Are you by any chance aware of such changes in the OGR JNI interface?
If you have to look, no problem, I'll do it, just wanted to see if it rings
a bell for you.
Ah, context, the store was developed against 1.9, linux distros are
currently shipping 1.11(.3)
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
