Thanks, so next steps are blog post and milestone release? -- Jody Garnett
On Wed, 28 Nov 2018 at 11:04, Torben Barsballe <tbarsba...@boundlessgeo.com> wrote: > This never quite got finished, so Jody and I finished most of what was > left last week (everything except spatialite), mostly going off of your > suggestions. The Post-sprint residues section of the spreadsheet has been > updated accordingly: > https://docs.google.com/spreadsheets/d/1oE6mU4jp-ZL5PebgXf-fuhtf7MY5dzSwPqpMtrzdZ94/edit#gid=2055024842 > > See also: > > - https://github.com/geotools/geotools/pull/2183 (merged to master) > - https://github.com/geotools/geotools/pull/2190 (pending) > > > Cheers, > Torben > > On Sat, Oct 27, 2018 at 9:50 AM Nuno Oliveira GeoSolutions < > nuno.olive...@geo-solutions.it> wrote: > >> Hi Andrea, >> please see my answers bellow: >> >> On Sat, Oct 27, 2018 at 2:35 PM Andrea Aime <andrea.a...@geo-solutions.it> >> wrote: >> >>> Hi, >>> after bringing the builds green I've looked at the jars to see if there >>> still are split packages. >>> Had to fix a couple of issues regarding SPI being declared in jars that >>> did not have the class being declared, >>> then finally got this: >>> >>> ./jsplitpkgscan -d /home/aaime/devel/git-gt/target/binaries >>> - Split packages: >>> it.geosolutions.jaiext.scale >>> 9 file:/jt-scale-1.1.2.jar >>> 9 file:/jt-scale2-1.1.2.jar >>> >>> I'll check with Daniele about this one. >>> >>> org.geotools >>> 1 file:/mp/gt-brewer-21-SNAPSHOT.jar >>> 1 file:/mp/gt-sample-data-21-SNAPSHOT.jar >>> >>> Brewer has a Builder interface there, only used inside the >>> brewer.styling package, >>> and gt-sample-data has TestData in there... I'd move down both and leave >>> the package empty. >>> >>> org.geotools.arcsde >>> 3 file:/mp/gt-arcsde-21-SNAPSHOT.jar >>> 1 file:/mp/gt-arcsde-common-21-SNAPSHOT.jar >>> >>> This is a bit more annoying, but can be solved by moving the sde >>> factories into org.geotools.arcsde.data, >>> which seems the right place >>> >>> org.geotools.data >>> 2 file:/mp/gt-data-21-SNAPSHOT.jar >>> 113 file:/mp/gt-main-21-SNAPSHOT.jar >>> >>> This is due to CachingFeatureSource, which has been deprecated for ages, >>> but unfortuntel >>> >>> org.geotools.data.complex >>> 35 file:/mp/gt-app-schema-21-SNAPSHOT.jar >>> 1 file:/mp/gt-complex-21-SNAPSHOT.jar >>> >>> This is mainly due to ComplexFeatureConstants in gt-complex... I'd move >>> it >>> in the util module. >>> >> >> I agree. >> >> >>> >>> org.geotools.data.complex.config >>> 13 file:/mp/gt-app-schema-21-SNAPSHOT.jar >>> 7 file:/mp/gt-complex-21-SNAPSHOT.jar >>> >>> Don't know what to do about this one >>> >> >> As for as I know, package org.geotools.data.complex.config in App-Schema >> module only contains App-Schema custom code, actually all the code in >> App-Schema module is strongly related with App-Schema so not sure there is >> a org.geotools.data.complex package inside it. >> >> I would suggest to move org.geotools.data.complex.config to >> org.geotools.appschema.config. >> >> >>> >>> org.geotools.data.complex.filter >>> 15 file:/mp/gt-app-schema-21-SNAPSHOT.jar >>> 4 file:/mp/gt-complex-21-SNAPSHOT.jar >>> >>> Due to a lone XPathUtil in gt-app-schema, seems movable to gt-complex >>> >> >> I agree. >> >> >>> >>> org.geotools.data.memory >>> 12 file:/mp/gt-data-21-SNAPSHOT.jar >>> 1 file:/mp/gt-main-21-SNAPSHOT.jar >>> >>> Due to a lone CollectionSource in gt-main... seems movable to gt-data >>> >>> org.geotools.data.store >>> 14 file:/mp/gt-data-21-SNAPSHOT.jar >>> 19 file:/mp/gt-main-21-SNAPSHOT.jar >>> >>> Ouch this one is painful, lots of classes on both sides >>> >>> org.geotools.metadata.iso.spatial >>> 7 file:/mp/gt-metadata-21-SNAPSHOT.jar >>> 1 file:/mp/gt-referencing-21-SNAPSHOT.jar >>> >>> Due to a lonely PixelTranslation in gt-referencing... needs to be >>> moved in another package, as it depends on other referencing classes. >>> I think org.geotools.geometry. >>> >>> org.geotools.styling >>> 131 file:/mp/gt-main-21-SNAPSHOT.jar >>> 2 file:/mp/gt-render-21-SNAPSHOT.jar >>> 1 file:/mp/gt-style-21-SNAPSHOT.jar >>> >>> gt-style only has one class (sees like an aborted split attempt, the >>> module was not >>> there before), gt-main a ton, gt-render only a couple that can be easily >>> moved to >>> gt-main or gt-style. >>> >>> org.locationtech.jts.geom >>> 48 file:/jts-core-1.16.0.jar >>> 1 file:/mp/gt-xsd-gml3-21-SNAPSHOT.jar >>> >>> gt-xsd-gml3 has a EmptyGeometry in that package, which is used by >>> app-schema only, >>> as far as I can tell. The class has no copyright header and no javadocs, >>> has been there >>> for a long time. I'd move it to org.geotools.geometry.jts >>> >>> org.sqlite >>> 1 file:/spatialite-jdbc-3.7.2-2.4.jar >>> 28 file:/sqlite-jdbc-3.23.1.jar >>> >>> Eh, there is not much that can be done, the spatialite-jdbc jar is sort >>> of a fork of sqlitejdbc >>> but with the native libs of spatialite inside. The module is really old, >>> spatialite has moved >>> forward and what we have is quite outdated, even if still building. >>> >> >> >>> The module needs a new maintainer... should we drop it down to >>> unsupported and out of the build? >>> (personally I'm already maintaining way too many modules, cannot take >>> any more unless I can >>> look after them during working hours). >>> >> >> Since there was a few doubts about this module some months ago I would >> suggest to send a mail tot he ML before moving it to unsupported, if nobody >> is interested ... well +1 to move it to unsupported land. >> >> >>> >>> Anyhow, I'll start looking at a few of the above, and create entries in >>> the spreadsheed for them, >>> if you want to join or follow up hop on gitter and/or check the >>> spreadsheet >>> >> >> If nobody complains I will move the App-Schema ones and any others I can. >> >> >>> >>> Cheers >>> Andrea >>> >>> == >>> >>> GeoServer Professional Services from the experts! Visit >>> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf >>> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa >>> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 >>> http://www.geo-solutions.it http://twitter.com/geosolutions_it >>> ------------------------------------------------------- *Con >>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail.* >>> _______________________________________________ >>> GeoTools-Devel mailing list >>> GeoTools-Devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> >> >> -- >> Regards, >> Nuno Oliveira >> == >> GeoServer Professional Services from the experts! >> Visit http://goo.gl/it488V for more information. >> == >> >> Nuno Miguel Carvalho Oliveira >> @nmcoliveira >> Software Engineer >> >> GeoSolutions S.A.S. >> Via di Montramito 3/A >> 55054 Massarosa (LU) >> Italy >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> ------------------------------------------------------- >> >> Con riferimento alla normativa sul trattamento dei dati >> personali (Reg. UE 2016/679 - Regolamento generale sulla >> protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, >> gli eventuali allegati, etc.) è un dato la cui conoscenza >> è riservata al/i solo/i destinatario/i indicati dallo >> scrivente. Se il messaggio Le è giunto per errore, è >> tenuta/o a cancellarlo, ogni altra operazione è illecita. >> Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to >> which it is addressed and may contain information that >> is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European >> Regulation 2016/679 “GDPR” - copying, dissemination or >> use of this e-mail or the information herein by anyone >> other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify >> us immediately by telephone or e-mail. >> _______________________________________________ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
